From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9605 invoked by alias); 6 Jan 2011 18:05:41 -0000 Received: (qmail 9595 invoked by uid 22791); 6 Jan 2011 18:05:40 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 06 Jan 2011 18:05:33 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 6403B1345E; Thu, 6 Jan 2011 10:05:32 -0800 (PST) Received: from msnyder-server.eng.vmware.com (promd-2s-dhcp138.eng.vmware.com [10.20.124.138]) by mailhost4.vmware.com (Postfix) with ESMTP id 4F69AC9BB6; Thu, 6 Jan 2011 10:05:32 -0800 (PST) Message-ID: <4D26046B.5060003@vmware.com> Date: Thu, 06 Jan 2011 18:05:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.24 (X11/20101201) MIME-Version: 1.0 To: Joel Brobecker CC: Pierre Muller , "gdb-patches@sourceware.org" Subject: Re: [patch] Shorten lines of >= 80 columns. References: <4D237089.1080309@vmware.com> <000c01cbac44$48830210$d9890630$@muller@ics-cnrs.unistra.fr> <4D237C6A.9050609@vmware.com> <000001cbacb7$4fc38f40$ef4aadc0$@muller@ics-cnrs.unistra.fr> <4D24B777.4030403@vmware.com> <4D24E4B9.40500@vmware.com> <20110106043158.GB28888@adacore.com> In-Reply-To: <20110106043158.GB28888@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-01/txt/msg00134.txt.bz2 Joel Brobecker wrote: >> internal_error (__FILE__, __LINE__, >> _("gen_var_ref: LOC_CONST_BYTES " >> "symbols are not supported")); > > For one-line strings, I think that's an acceptable solution. In fact, > this might be a better solution, making the code as a whole more > readable (because it avoids the misindentation of the string that breaks > the formatting of the code as a whole). > > For multi-line strings, such as help strings, etc, I think it will be > easier to still use the style that you originally chose. For instance: > > | warning (_("\ > | Private mapping of shared library text was not specified\n\ > | by the executable; setting a breakpoint in a shared library which\n\ > | is not privately mapped will not work. See the HP-UX 11i v3 chatr\n\ > | manpage for methods to privately map shared library text.")); > > I think that, for multi-line strings, this makes easier to read the > entire text, and it also makes it easier to make sure that the string > is of reasonable size (ie, under 80, or 76, or 74). > > The typical case where these are used are the _init routines, where > we create new commands. The help strings can easily need to have > more than one line (if it was me, I would put as much information > in the help command as in the manual). Yeah, you're right. I'll try to put some of them back.