[testcase patch] 7.2 regression on expand psymtabs

[testcase patch] 7.2 regression on expand psymtabs

[Jan Kratochvil]

Hi Keith,

there is a regression by the patch:
	42284fdf9d8cdb20c8e833bdbdb2b56977fea525
	http://sourceware.org/ml/gdb-cvs/2010-03/msg00082.html
	dwarf2_physname patchset:
	[RFA] dwarf2_physname FINAL
	http://sourceware.org/ml/gdb-patches/2010-03/msg00220.html

(Have not filed a PR to KFAIL it, to be checked in with a fix.)


Thanks,
Jan


gdb/testsuite/
2010-11-21  Jan Kratochvil  <jan.kratochvil@redhat.com>

	* gdb.cp/expand-psymtabs-cxx.exp: New file.
	* gdb.cp/expand-psymtabs-cxx.cc: New file.

--- /dev/null
+++ b/gdb/testsuite/gdb.cp/expand-psymtabs-cxx.cc
@@ -0,0 +1,21 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+   Copyright 2010 Free Software Foundation, Inc.
+
+   This program is free software; you can redistribute it and/or modify
+   it under the terms of the GNU General Public License as published by
+   the Free Software Foundation; either version 3 of the License, or
+   (at your option) any later version.
+
+   This program is distributed in the hope that it will be useful,
+   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+   GNU General Public License for more details.
+
+   You should have received a copy of the GNU General Public License
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
+
+void
+method (long x)
+{
+}
--- /dev/null
+++ b/gdb/testsuite/gdb.cp/expand-psymtabs-cxx.exp
@@ -0,0 +1,37 @@
+# Copyright 2010 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA.
+#
+# This file is part of the gdb testsuite.
+
+set testfile expand-psymtabs-cxx
+set srcfile ${testfile}.cc
+set executable ${testfile}.x
+set binfile ${objdir}/${subdir}/${executable}
+
+if  { [gdb_compile "${srcdir}/${subdir}/${srcfile}" "${binfile}" object {debug c++} ] != "" } {
+     untested ${testfile}.exp
+     return -1
+}
+
+clean_restart ${executable}
+
+gdb_test_no_output "set language c++"
+
+# FAIL was:
+# $1 = {<text variable, no debug info>} 0
+gdb_test "p 'method(long)'" { = {void \(long\)} 0} "before expand"
+gdb_test "p method" { = {void \(long\)} 0} "force expand"
+gdb_test "p 'method(long)'" { = {void \(long\)} 0} "after expand"

Re: [testcase patch] 7.2 regression on expand psymtabs

[Joel Brobecker]

> there is a regression by the patch:
> 	42284fdf9d8cdb20c8e833bdbdb2b56977fea525
> 	http://sourceware.org/ml/gdb-cvs/2010-03/msg00082.html
> 	dwarf2_physname patchset:
> 	[RFA] dwarf2_physname FINAL
> 	http://sourceware.org/ml/gdb-patches/2010-03/msg00220.html
> 
> (Have not filed a PR to KFAIL it, to be checked in with a fix.)

Sorry to be so behind on gdb-patches email.  Has this been resolved?
Does it affect the 7.2.1 release?

Thanks,
-- 
Joel

Re: [testcase patch] 7.2 regression on expand psymtabs

[Keith Seitz]

On 12/13/2010 11:06 PM, Joel Brobecker wrote:

> Sorry to be so behind on gdb-patches email.  Has this been resolved?
> Does it affect the 7.2.1 release?

This is c++/11734 (psymtab expansion of overloaded methods), for which I 
have an outstanding patch. Tom has asked me to make a few API changes to 
support it, but yesterday I got tangled in decode_compound again, and I 
didn't get back to 11734. I'll give c++/11734 my top priority today.

I'm sure it affects every release since the original dwarf2_physname 
patch was committed in March.

Keith

Re: [testcase patch] 7.2 regression on expand psymtabs

[Tom Tromey]

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> Sorry to be so behind on gdb-patches email.  Has this been resolved?

Keith wrote a follow-up patch, which I reviewed.
He's updating it.

Joel> Does it affect the 7.2.1 release?

Yes.

Tom

Re: [testcase patch] 7.2 regression on expand psymtabs

[Jan Kratochvil]

Hi Keith,

original post: http://sourceware.org/ml/gdb-patches/2010-11/msg00300.html

On Sun, 21 Nov 2010 22:30:20 +0100, Jan Kratochvil wrote:
> there is a regression by the patch:
> 	42284fdf9d8cdb20c8e833bdbdb2b56977fea525
> 	http://sourceware.org/ml/gdb-cvs/2010-03/msg00082.html
> 	dwarf2_physname patchset:
> 	[RFA] dwarf2_physname FINAL
> 	http://sourceware.org/ml/gdb-patches/2010-03/msg00220.html
[...]
> gdb/testsuite/
> 2010-11-21  Jan Kratochvil  <jan.kratochvil@redhat.com>
> 
> 	* gdb.cp/expand-psymtabs-cxx.exp: New file.
> 	* gdb.cp/expand-psymtabs-cxx.cc: New file.

I have found this testfile by me went FAIL->PASS by:

Re: [patch 0/3] Re: [RFA] c++/11734 revisited (and c++/12273)
http://sourceware.org/ml/gdb-patches/2011-03/msg00880.html

= two commits:

commit 9e2e8e2f9323fe17ceafb49d8eca9e3117947066
Author: Keith Seitz <keiths@redhat.com>
Date:   Wed Mar 16 21:12:11 2011 +0000

        * linespec.c (find_methods): Canonicalize NAME before looking
        up the symbol.
        (name_end): New function.
        (keep_name_info): New function.
        (decode_line_1): Use keep_name_info.
        (decode_compound): Likewise.
        * cli/cli-utils.h (remove_trailing_whitespace): New function.
        * cli/cli-utils.c (remove_trailing_whitespace): Likewise.
    
        PR c++/12273
        * linespec.c (locate_first_half): Keep overload information, too.
        (decode_compound): Use a string to represent break characters
        to escape the loop.
        If P points to a break character, do not increment it.
        For C++ and Java, keep overload information and relevant keywords.
        If we cannot find a symbol, search the minimal symbols.
    
        PR c++/11734
        * linespec.c (decode_compound): Rename SAVED_ARG to
        THE_REAL_SAVED_ARG.
        Make a copy of THE_REAL_SAVED_ARG in SAVED_ARG and strip
        single-quotes.
        Pass a valid block to lookup_symbol.
        (lookup_prefix_sym): Likewise.
        (find_method): Construct search name based on SYM_CLASS instead
        of SAVED_ARG.
        * psymtab.c (lookup_partial_symbol): Add language parameter.
        (lookup_symbol_aux_psymtabs): Likewise.
        Don't assume that the psymtab we found was the right one. Search
        for the desired symbol in the symtab to be certain.
        (psymtab_search_name): New function.
        (lookup_partial_symbol): Use psymtab_search_name.
        Add language parameter.
        (read_symtabs_for_function): Add language parameter and pass to
        lookup_partial_symbol.
        (find_symbol_file_from_partial): Likewise.

commit bb108bccb87a6e3b166a2ba74cc3aaf192c687ff
Author: Keith Seitz <keiths@redhat.com>
Date:   Wed Mar 16 21:08:56 2011 +0000

	PR c++/12273
	* gdb.cp/cmpd-minsyms.exp: New test.
	* gdb.cp/cmpd-minsyms.cc: New file.
    
	PR c++/11734
	* gdb.cp/ovsrch.exp: New test.
	* gdb.cp/ovsrch.h: New file.
	* gdb.cp/ovsrch1.cc: New file.
	* gdb.cp/ovsrch2.cc: New file.
	* gdb.cp/ovsrch3.cc: New file.
	* gdb.cp/ovsrch4.cc: New file.

I think these testcases do not cover the issue tested by this posted testfile.
Therefore going to check it in unless you tell otherwise.  A redundant
testfile would not be such a tragedy anyway.


Thanks,
Jan

[commit] [testcase patch] 7.2 regression on expand psymtabs

[Jan Kratochvil]

On Fri, 21 Oct 2011 16:17:33 +0200, Jan Kratochvil wrote:
> Therefore going to check it in unless you tell otherwise.  A redundant
> testfile would not be such a tragedy anyway.

Checked in:
	http://sourceware.org/ml/gdb-cvs/2011-10/msg00159.html


Thanks,
Jan