From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30520 invoked by alias); 21 Oct 2011 14:17:59 -0000 Received: (qmail 30505 invoked by uid 22791); 21 Oct 2011 14:17:58 -0000 X-SWARE-Spam-Status: No, hits=-6.1 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Oct 2011 14:17:38 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p9LEHcpr028157 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 21 Oct 2011 10:17:38 -0400 Received: from host1.jankratochvil.net (ovpn-116-16.ams2.redhat.com [10.36.116.16]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p9LEHa65019857 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 21 Oct 2011 10:17:37 -0400 Received: from host1.jankratochvil.net (localhost [127.0.0.1]) by host1.jankratochvil.net (8.14.4/8.14.4) with ESMTP id p9LEHYip018216; Fri, 21 Oct 2011 16:17:34 +0200 Received: (from jkratoch@localhost) by host1.jankratochvil.net (8.14.4/8.14.4/Submit) id p9LEHY1N018205; Fri, 21 Oct 2011 16:17:34 +0200 Date: Fri, 21 Oct 2011 15:31:00 -0000 From: Jan Kratochvil To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [testcase patch] 7.2 regression on expand psymtabs Message-ID: <20111021141733.GA32350@host1.jankratochvil.net> References: <20101121213020.GA26240@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101121213020.GA26240@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-10/txt/msg00593.txt.bz2 Hi Keith, original post: http://sourceware.org/ml/gdb-patches/2010-11/msg00300.html On Sun, 21 Nov 2010 22:30:20 +0100, Jan Kratochvil wrote: > there is a regression by the patch: > 42284fdf9d8cdb20c8e833bdbdb2b56977fea525 > http://sourceware.org/ml/gdb-cvs/2010-03/msg00082.html > dwarf2_physname patchset: > [RFA] dwarf2_physname FINAL > http://sourceware.org/ml/gdb-patches/2010-03/msg00220.html [...] > gdb/testsuite/ > 2010-11-21 Jan Kratochvil > > * gdb.cp/expand-psymtabs-cxx.exp: New file. > * gdb.cp/expand-psymtabs-cxx.cc: New file. I have found this testfile by me went FAIL->PASS by: Re: [patch 0/3] Re: [RFA] c++/11734 revisited (and c++/12273) http://sourceware.org/ml/gdb-patches/2011-03/msg00880.html = two commits: commit 9e2e8e2f9323fe17ceafb49d8eca9e3117947066 Author: Keith Seitz Date: Wed Mar 16 21:12:11 2011 +0000 * linespec.c (find_methods): Canonicalize NAME before looking up the symbol. (name_end): New function. (keep_name_info): New function. (decode_line_1): Use keep_name_info. (decode_compound): Likewise. * cli/cli-utils.h (remove_trailing_whitespace): New function. * cli/cli-utils.c (remove_trailing_whitespace): Likewise. PR c++/12273 * linespec.c (locate_first_half): Keep overload information, too. (decode_compound): Use a string to represent break characters to escape the loop. If P points to a break character, do not increment it. For C++ and Java, keep overload information and relevant keywords. If we cannot find a symbol, search the minimal symbols. PR c++/11734 * linespec.c (decode_compound): Rename SAVED_ARG to THE_REAL_SAVED_ARG. Make a copy of THE_REAL_SAVED_ARG in SAVED_ARG and strip single-quotes. Pass a valid block to lookup_symbol. (lookup_prefix_sym): Likewise. (find_method): Construct search name based on SYM_CLASS instead of SAVED_ARG. * psymtab.c (lookup_partial_symbol): Add language parameter. (lookup_symbol_aux_psymtabs): Likewise. Don't assume that the psymtab we found was the right one. Search for the desired symbol in the symtab to be certain. (psymtab_search_name): New function. (lookup_partial_symbol): Use psymtab_search_name. Add language parameter. (read_symtabs_for_function): Add language parameter and pass to lookup_partial_symbol. (find_symbol_file_from_partial): Likewise. commit bb108bccb87a6e3b166a2ba74cc3aaf192c687ff Author: Keith Seitz Date: Wed Mar 16 21:08:56 2011 +0000 PR c++/12273 * gdb.cp/cmpd-minsyms.exp: New test. * gdb.cp/cmpd-minsyms.cc: New file. PR c++/11734 * gdb.cp/ovsrch.exp: New test. * gdb.cp/ovsrch.h: New file. * gdb.cp/ovsrch1.cc: New file. * gdb.cp/ovsrch2.cc: New file. * gdb.cp/ovsrch3.cc: New file. * gdb.cp/ovsrch4.cc: New file. I think these testcases do not cover the issue tested by this posted testfile. Therefore going to check it in unless you tell otherwise. A redundant testfile would not be such a tragedy anyway. Thanks, Jan