From: Jie Zhang <jie@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: Fix Makefile.in in data-directory
Date: Thu, 21 Oct 2010 23:52:00 -0000 [thread overview]
Message-ID: <4CC0D237.5020905@codesourcery.com> (raw)
In-Reply-To: <AANLkTinCWDtFtnseZ4tt1EeFTUkCR+6_TwBk9G==MhXu@mail.gmail.com>
On 10/22/2010 05:05 AM, Doug Evans wrote:
> On Wed, Oct 20, 2010 at 10:11 PM, Jie Zhang<jie@codesourcery.com> wrote:
>> Reasonable although I never used it before. This is an updated patch which
>> does that. It fixes it by passing FLAGS_TO_PASS when recursively make
>> install-only. It fixes my issue. I also tested by touching a source file and
>> do "make -j4 install" in gdb directory. It behaves as expected. OK now?
>
> Thanks for persevering.
>
> The patch is fine with me, though there is one obvious improvement.
> It could be left for another pass.
>
> FLAGS_TO_PASS is big, and there are now multiple copies of it.
> IWBN if there were only one copy.
> I wonder how much duplication there is in the makefiles, and if a
> Makefile.common is reasonable. It could be pasted in by configure.
> [I realize gdbserver has its own configure, but it could, I think,
> still use the same Makefile.common.]
> I'm not sure it's warranted just for FLAGS_TO_PASS, so it could be
> left for another day.
>
> Feel free to check this in as is if you prefer.
Committed now. Thanks.
--
Jie Zhang
CodeSourcery
next prev parent reply other threads:[~2010-10-21 23:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 12:09 Jie Zhang
2010-10-20 20:13 ` Doug Evans
2010-10-21 0:10 ` Jie Zhang
2010-10-21 0:14 ` Pedro Alves
2010-10-21 0:17 ` Jie Zhang
2010-10-21 0:29 ` Pedro Alves
2010-10-21 2:15 ` Jie Zhang
2010-10-21 2:30 ` Doug Evans
2010-10-21 5:11 ` Jie Zhang
2010-10-21 21:06 ` Doug Evans
2010-10-21 23:52 ` Jie Zhang [this message]
2010-10-21 10:07 ` Pedro Alves
2010-10-21 14:46 ` Joel Brobecker
2010-10-22 1:14 ` Tom Tromey
2010-10-21 21:08 ` Doug Evans
2010-10-22 1:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CC0D237.5020905@codesourcery.com \
--to=jie@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox