From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13547 invoked by alias); 21 Oct 2010 23:52:35 -0000 Received: (qmail 13539 invoked by uid 22791); 21 Oct 2010 23:52:34 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Oct 2010 23:52:28 +0000 Received: (qmail 12238 invoked from network); 21 Oct 2010 23:52:26 -0000 Received: from unknown (HELO ?192.168.1.106?) (jie@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Oct 2010 23:52:26 -0000 Message-ID: <4CC0D237.5020905@codesourcery.com> Date: Thu, 21 Oct 2010 23:52:00 -0000 From: Jie Zhang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100918 Icedove/3.1.4 MIME-Version: 1.0 To: Doug Evans CC: Pedro Alves , gdb-patches@sourceware.org Subject: Re: Fix Makefile.in in data-directory References: <4CBEDBF5.9060504@codesourcery.com> <201010210114.24465.pedro@codesourcery.com> <4CBF86A6.8020102@codesourcery.com> <201010210128.53843.pedro@codesourcery.com> <4CBFA227.8050501@codesourcery.com> <4CBFCB92.5020204@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00345.txt.bz2 On 10/22/2010 05:05 AM, Doug Evans wrote: > On Wed, Oct 20, 2010 at 10:11 PM, Jie Zhang wrote: >> Reasonable although I never used it before. This is an updated patch which >> does that. It fixes it by passing FLAGS_TO_PASS when recursively make >> install-only. It fixes my issue. I also tested by touching a source file and >> do "make -j4 install" in gdb directory. It behaves as expected. OK now? > > Thanks for persevering. > > The patch is fine with me, though there is one obvious improvement. > It could be left for another pass. > > FLAGS_TO_PASS is big, and there are now multiple copies of it. > IWBN if there were only one copy. > I wonder how much duplication there is in the makefiles, and if a > Makefile.common is reasonable. It could be pasted in by configure. > [I realize gdbserver has its own configure, but it could, I think, > still use the same Makefile.common.] > I'm not sure it's warranted just for FLAGS_TO_PASS, so it could be > left for another day. > > Feel free to check this in as is if you prefer. Committed now. Thanks. -- Jie Zhang CodeSourcery