From: Jie Zhang <jie@codesourcery.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix Makefile.in in data-directory
Date: Thu, 21 Oct 2010 00:10:00 -0000 [thread overview]
Message-ID: <4CBF84E6.6020100@codesourcery.com> (raw)
In-Reply-To: <AANLkTi=ZusdpB4=kcF_0tAPEQkPEuNwdXhrhQDTfw_fs@mail.gmail.com>
On 10/21/2010 04:13 AM, Doug Evans wrote:
> On Wed, Oct 20, 2010 at 5:09 AM, Jie Zhang<jie@codesourcery.com> wrote:
>>
>> The current install rule in the Makefile.in of data-directory uses recursive make but does not pass FLAGS_TO_PASS. This causes an issue when people try to override prefix with command line option "make install", i.e. data-directory will still be installed under the configure time prefix. This patch fixes it. OK?
>
> [Apologies for the resend.]
>
> Thanks for the bug report. Forgot about that.
>
> This patch is not ok though. A parallel make (e.g. -jN) might try to
> build all and install-only simultaneously.
>
> maybe:
> $(MAKE) install-only $(FLAGS_TO_PASS)
>
>
> For reference sake, there are other instances of "install: all install-only".
> They need to be fixed too.
I don't think this is an issue. I think in the last more than 10 years,
no one did "make -j all install" since the same instance in
gdb/Makefile.in has been there since it was created. Actually if you do
that in current gdb, it will not install gdb at all. I usually issue
make -j4 all
make install
to make gdb. I believe people have been used to do that in this way
after so many years. So I think it's not an issue to do the same for
data-directory. No?
--
Jie Zhang
CodeSourcery
next prev parent reply other threads:[~2010-10-21 0:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 12:09 Jie Zhang
2010-10-20 20:13 ` Doug Evans
2010-10-21 0:10 ` Jie Zhang [this message]
2010-10-21 0:14 ` Pedro Alves
2010-10-21 0:17 ` Jie Zhang
2010-10-21 0:29 ` Pedro Alves
2010-10-21 2:15 ` Jie Zhang
2010-10-21 2:30 ` Doug Evans
2010-10-21 5:11 ` Jie Zhang
2010-10-21 21:06 ` Doug Evans
2010-10-21 23:52 ` Jie Zhang
2010-10-21 10:07 ` Pedro Alves
2010-10-21 14:46 ` Joel Brobecker
2010-10-22 1:14 ` Tom Tromey
2010-10-21 21:08 ` Doug Evans
2010-10-22 1:11 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CBF84E6.6020100@codesourcery.com \
--to=jie@codesourcery.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox