From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15668 invoked by alias); 21 Oct 2010 00:10:16 -0000 Received: (qmail 15660 invoked by uid 22791); 21 Oct 2010 00:10:15 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Oct 2010 00:10:10 +0000 Received: (qmail 14022 invoked from network); 21 Oct 2010 00:10:08 -0000 Received: from unknown (HELO ?192.168.1.106?) (jie@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Oct 2010 00:10:08 -0000 Message-ID: <4CBF84E6.6020100@codesourcery.com> Date: Thu, 21 Oct 2010 00:10:00 -0000 From: Jie Zhang User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100918 Icedove/3.1.4 MIME-Version: 1.0 To: Doug Evans CC: gdb-patches@sourceware.org Subject: Re: Fix Makefile.in in data-directory References: <4CBEDBF5.9060504@codesourcery.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00326.txt.bz2 On 10/21/2010 04:13 AM, Doug Evans wrote: > On Wed, Oct 20, 2010 at 5:09 AM, Jie Zhang wrote: >> >> The current install rule in the Makefile.in of data-directory uses recursive make but does not pass FLAGS_TO_PASS. This causes an issue when people try to override prefix with command line option "make install", i.e. data-directory will still be installed under the configure time prefix. This patch fixes it. OK? > > [Apologies for the resend.] > > Thanks for the bug report. Forgot about that. > > This patch is not ok though. A parallel make (e.g. -jN) might try to > build all and install-only simultaneously. > > maybe: > $(MAKE) install-only $(FLAGS_TO_PASS) > > > For reference sake, there are other instances of "install: all install-only". > They need to be fixed too. I don't think this is an issue. I think in the last more than 10 years, no one did "make -j all install" since the same instance in gdb/Makefile.in has been there since it was created. Actually if you do that in current gdb, it will not install gdb at all. I usually issue make -j4 all make install to make gdb. I believe people have been used to do that in this way after so many years. So I think it's not an issue to do the same for data-directory. No? -- Jie Zhang CodeSourcery