Re: [RFC] Use custom hash function with bcache

[sami wagiaalla <swagiaal@redhat.com>]

> Aha!  OK, I get it now.  And the section is probably never used for
> psymbols, right?
>

It might be if the symbol is a C++ symbol and has a demangled name.

> I think that the way you've got this is probably OK, but could stand
> some more explanation.

I will update the comments to reflect the result our discussions here.

   It kind of pains me, though, because there's
> an obvious missed optimization that I don't see how to do efficiently.
> We don't need to do the work of SYMBOL_SET_NAMES again if there's already a
> named version in the cache...
>

Hmm... this is probably a separate patch, but how about this: 
symbol_set_names sets the mangled and demangled names we need at least 
the mangled name to find out wether there is already a name version in 
the bcache. So maybe we could only set the mangled name, check the 
bcache and only set the demangled name after we have consulted the 
bcache. This only works of course if we ignore the demangled name as is 
in this patch (Do you agree that this is OK btw ?).