Re: Regression for gdb.stabs/gdb11479.exp [Re: [patch 1/2] Use custom hash function with bcache]

[Joel Brobecker <brobecker@adacore.com>]

> > 2010-08-25  Sami Wagiaalla  <swagiaal@redhat.com>
> > 
> > 	* psymtab.c (add_psymbol_to_bcache): Remove 'static' from
> > 	'static partial_symbol psymbol'.
> > 	(psymbol_hash): New function.
> > 	(psymbol_compare): New function.
> > 	* bcache.c (hash_continue): New.
> > 	(hash): Use hash_continue.
> > 	* bcache.c: Add hash_function and compare_function
> > 	pointers to bcache struct.
> > 	(bcache_full): Use bcache->hash_function, and
> > 	bcache->compare_function.
> > 	(bcache_compare): New function.
> > 	(bcache_xmalloc): Take hash_function and
> > 	compare_function arguments and initialize the
> > 	bcach's pointers.
> > 	Updated comment.
> > 	* objfiles.c (allocate_objfile): Updated.
> > 	* symfile.c (reread_symbols): Updated.
> 
> fb846e72510040325bffd8f755180ea0025108dc
> http://sourceware.org/ml/gdb-cvs/2010-08/msg00197.html
> 
> It has a regression for gdb.stabs/gdb11479.exp on all the tested distros
> {x86_64,x86_64-m32,i686}-fedora{12,13,14snapshot}-linux-gnu even without
> -lmcheck.

Just so we don't duplicate efforts, I've have been looking into this.
I'm not completely done, yet, but I've found something suspicious.
For me, it causes a crash in gdb.ada/complete.exp:

    (gdb) b 7
    Breakpoint 1 at 0x401f96: file /[...]/foo.adb, line 7.
    (gdb) run
    Starting program: /[...]/foo 
    
    Breakpoint 1, foo () at /[...]/foo.adb:7
    7          My_Global_Variable := Some_Local_Variable + 1; -- START
    (gdb) complete p my_glob
    [1]    22302 segmentation fault  ../../../gdb foo


-- 
Joel