From: Stan Shebs <stan@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: GDB <gdb-patches@sourceware.org>
Subject: Re: Missing 0x in phex_nz output
Date: Thu, 01 Apr 2010 22:50:00 -0000 [thread overview]
Message-ID: <4BB52329.7070807@codesourcery.com> (raw)
In-Reply-To: <z2u6dc9ffc81004011542i4a86f14el4537e1090ffe77@mail.gmail.com>
H.J. Lu wrote:
> Hi,
>
> phex_nz returns a string of hex number. But 0x is missing in many outputs:
>
> m32r-rom.c: monitor_printf ("%s mw\r", phex_nz (section_base, addr_size));
> monitor.c: monitor_printf ("%s\r", phex_nz (val, reg_size));
> monitor.c: monitor_printf ("%s\r", phex_nz (val, reg_size));
> remote.c: xsnprintf (buf, get_remote_packet_size (), "P%s=", phex_nz
> (reg->pnum, 0));
> remote.c: sprintf (p, "pc:%s", phex_nz (addr1, 0));
> remote.c: sprintf (p, "range:%s:%s", phex_nz (addr1, 0), phex_nz
> (addr2, 0));
> remote.c: sprintf (p, "outside:%s:%s", phex_nz (addr1, 0),
> phex_nz (addr2, 0));
>
All these cases are ones in which interface protocol prescribes that the
values be hexadecimal, but with no qualifying prefix.
Stan
next prev parent reply other threads:[~2010-04-01 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 22:42 H.J. Lu
2010-04-01 22:50 ` Stan Shebs [this message]
2010-04-01 22:51 ` Pedro Alves
2010-04-01 22:54 ` H.J. Lu
2010-04-01 23:04 ` Pedro Alves
2010-04-01 23:13 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BB52329.7070807@codesourcery.com \
--to=stan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox