From: Pedro Alves <pedro@codesourcery.com>
To: "H.J. Lu" <hjl.tools@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Missing 0x in phex_nz output
Date: Thu, 01 Apr 2010 23:04:00 -0000 [thread overview]
Message-ID: <201004020004.45852.pedro@codesourcery.com> (raw)
In-Reply-To: <x2w6dc9ffc81004011554y17dc40f9p60b6907f3052d127@mail.gmail.com>
On Thursday 01 April 2010 23:54:30, H.J. Lu wrote:
> How about this one?
>
Use hex_string instead of adding the "0x"; it does
that for you. Preaproved with that change.
>
> --
> H.J.
> diff --git a/gdb/remote.c b/gdb/remote.c
> index 395a56d..bb80afb 100644
> --- a/gdb/remote.c
> +++ b/gdb/remote.c
> @@ -4882,7 +4882,7 @@ Packet: '%s'\n"),
> ++p;
>
> if (reg == NULL)
> - error (_("Remote sent bad register number %s: %s\n\
> + error (_("Remote sent bad register number 0x%s: %s\n\
> Packet: '%s'\n"),
> phex_nz (pnum, 0), p, buf);
--
Pedro Alves
next prev parent reply other threads:[~2010-04-01 23:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 22:42 H.J. Lu
2010-04-01 22:50 ` Stan Shebs
2010-04-01 22:51 ` Pedro Alves
2010-04-01 22:54 ` H.J. Lu
2010-04-01 23:04 ` Pedro Alves [this message]
2010-04-01 23:13 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004020004.45852.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=hjl.tools@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox