From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 437 invoked by alias); 1 Apr 2010 23:04:55 -0000 Received: (qmail 350 invoked by uid 22791); 1 Apr 2010 23:04:53 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 23:04:49 +0000 Received: (qmail 31962 invoked from network); 1 Apr 2010 23:04:47 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Apr 2010 23:04:47 -0000 From: Pedro Alves To: "H.J. Lu" Subject: Re: Missing 0x in phex_nz output Date: Thu, 01 Apr 2010 23:04:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-20-generic; KDE/4.3.2; x86_64; ; ) Cc: gdb-patches@sourceware.org References: <201004012351.20183.pedro@codesourcery.com> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201004020004.45852.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00034.txt.bz2 On Thursday 01 April 2010 23:54:30, H.J. Lu wrote: > How about this one? > Use hex_string instead of adding the "0x"; it does that for you. Preaproved with that change. > > -- > H.J. > diff --git a/gdb/remote.c b/gdb/remote.c > index 395a56d..bb80afb 100644 > --- a/gdb/remote.c > +++ b/gdb/remote.c > @@ -4882,7 +4882,7 @@ Packet: '%s'\n"), > ++p; > > if (reg == NULL) > - error (_("Remote sent bad register number %s: %s\n\ > + error (_("Remote sent bad register number 0x%s: %s\n\ > Packet: '%s'\n"), > phex_nz (pnum, 0), p, buf); -- Pedro Alves