From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3973 invoked by alias); 1 Apr 2010 22:50:34 -0000 Received: (qmail 3946 invoked by uid 22791); 1 Apr 2010 22:50:29 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=BAYES_00,TW_XS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 01 Apr 2010 22:50:24 +0000 Received: (qmail 23636 invoked from network); 1 Apr 2010 22:50:23 -0000 Received: from unknown (HELO macbook-2.local) (stan@127.0.0.2) by mail.codesourcery.com with ESMTPA; 1 Apr 2010 22:50:23 -0000 Message-ID: <4BB52329.7070807@codesourcery.com> Date: Thu, 01 Apr 2010 22:50:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.24 (Macintosh/20100228) MIME-Version: 1.0 To: "H.J. Lu" CC: GDB Subject: Re: Missing 0x in phex_nz output References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00031.txt.bz2 H.J. Lu wrote: > Hi, > > phex_nz returns a string of hex number. But 0x is missing in many outputs: > > m32r-rom.c: monitor_printf ("%s mw\r", phex_nz (section_base, addr_size)); > monitor.c: monitor_printf ("%s\r", phex_nz (val, reg_size)); > monitor.c: monitor_printf ("%s\r", phex_nz (val, reg_size)); > remote.c: xsnprintf (buf, get_remote_packet_size (), "P%s=", phex_nz > (reg->pnum, 0)); > remote.c: sprintf (p, "pc:%s", phex_nz (addr1, 0)); > remote.c: sprintf (p, "range:%s:%s", phex_nz (addr1, 0), phex_nz > (addr2, 0)); > remote.c: sprintf (p, "outside:%s:%s", phex_nz (addr1, 0), > phex_nz (addr2, 0)); > All these cases are ones in which interface protocol prescribes that the values be hexadecimal, but with no qualifying prefix. Stan