From: Stan Shebs <stanshebs@earthlink.net>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org,
Marc Khouzam <marc.khouzam@ericsson.com>,
Stan Shebs <stan@codesourcery.com>
Subject: Re: [PATCH] No resuming while tfinding
Date: Thu, 18 Mar 2010 00:59:00 -0000 [thread overview]
Message-ID: <4BA17AF9.9030107@earthlink.net> (raw)
In-Reply-To: <201003171521.59901.pedro@codesourcery.com>
Pedro Alves wrote:
>
>> (until_command): Ditto.
>>
>>
> This misses the "until" command, in breakpoint.c.
>
I'm guessing you mean until_break_command? It looks like it's lower
level to until_command and advance_command, and I'd like to keep this
test at the outermost levels, similarly to the "program is not running"
error.
>>
>> extern void disconnect_or_stop_tracing (int from_tty);
>> + extern int get_traceframe_number (void);
>>
>
> This is unnecessary, get_traceframe_number is declared in
> tracepoint.h. The disconnect_or_stop_tracing declaration
> shown above could use moving there as well...
>
Good idea, I'll fold that in.
Stan
next prev parent reply other threads:[~2010-03-18 0:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-17 1:59 Stan Shebs
2010-03-17 13:51 ` Marc Khouzam
2010-03-17 15:19 ` Joel Brobecker
2010-03-17 17:36 ` Michael Snyder
2010-03-17 23:40 ` Stan Shebs
2010-03-17 23:44 ` Pedro Alves
2010-03-17 15:22 ` Pedro Alves
2010-03-17 17:31 ` Stan Shebs
2010-03-18 0:59 ` Stan Shebs [this message]
2010-03-18 12:19 ` Pedro Alves
2010-03-18 13:23 ` Pedro Alves
2010-03-18 16:05 ` Tom Tromey
2010-03-18 17:47 ` Stan Shebs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA17AF9.9030107@earthlink.net \
--to=stanshebs@earthlink.net \
--cc=gdb-patches@sourceware.org \
--cc=marc.khouzam@ericsson.com \
--cc=pedro@codesourcery.com \
--cc=stan@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox