Re: [PATCH] No resuming while tfinding

[Pedro Alves <pedro@codesourcery.com>]

On Thursday 18 March 2010 00:59:37, Stan Shebs wrote:
> > This misses the "until" command, in breakpoint.c.
> >   
> I'm guessing you mean until_break_command?  It looks like it's lower 
> level to until_command and advance_command, and I'd like to keep this 
> test at the outermost levels, similarly to the "program is not running" 
> error.

Ah, indeed.  Thanks.

Hmm, it seems I missed adding ensure_not_running to those then.  Also, this
in both until_command and advance_command:

    if (!target_has_execution)
      error (_("The program is not running."));

could be replaced by ERROR_NO_INFERIOR.

> >>   
> >>   extern void disconnect_or_stop_tracing (int from_tty);
> >> + extern int get_traceframe_number (void);
> >>     
> >
> > This is unnecessary, get_traceframe_number is declared in
> > tracepoint.h.  The disconnect_or_stop_tracing declaration
> > shown above could use moving there as well...
> >   
> Good idea, I'll fold that in.

Thanks.

-- 
Pedro Alves