From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28707 invoked by alias); 18 Mar 2010 12:19:21 -0000 Received: (qmail 28694 invoked by uid 22791); 18 Mar 2010 12:19:21 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 12:19:15 +0000 Received: (qmail 4968 invoked from network); 18 Mar 2010 12:19:14 -0000 Received: from unknown (HELO orlando.localnet) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Mar 2010 12:19:14 -0000 From: Pedro Alves To: Stan Shebs Subject: Re: [PATCH] No resuming while tfinding Date: Thu, 18 Mar 2010 12:19:00 -0000 User-Agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; ) Cc: gdb-patches@sourceware.org, Marc Khouzam , Stan Shebs References: <4BA0377C.1040000@codesourcery.com> <201003171521.59901.pedro@codesourcery.com> <4BA17AF9.9030107@earthlink.net> In-Reply-To: <4BA17AF9.9030107@earthlink.net> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201003181219.11065.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00656.txt.bz2 On Thursday 18 March 2010 00:59:37, Stan Shebs wrote: > > This misses the "until" command, in breakpoint.c. > > > I'm guessing you mean until_break_command? It looks like it's lower > level to until_command and advance_command, and I'd like to keep this > test at the outermost levels, similarly to the "program is not running" > error. Ah, indeed. Thanks. Hmm, it seems I missed adding ensure_not_running to those then. Also, this in both until_command and advance_command: if (!target_has_execution) error (_("The program is not running.")); could be replaced by ERROR_NO_INFERIOR. > >> > >> extern void disconnect_or_stop_tracing (int from_tty); > >> + extern int get_traceframe_number (void); > >> > > > > This is unnecessary, get_traceframe_number is declared in > > tracepoint.h. The disconnect_or_stop_tracing declaration > > shown above could use moving there as well... > > > Good idea, I'll fold that in. Thanks. -- Pedro Alves