From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4172 invoked by alias); 18 Mar 2010 00:59:46 -0000 Received: (qmail 4100 invoked by uid 22791); 18 Mar 2010 00:59:44 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from elasmtp-kukur.atl.sa.earthlink.net (HELO elasmtp-kukur.atl.sa.earthlink.net) (209.86.89.65) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 00:59:40 +0000 Received: from [70.170.59.51] (helo=macbook-2.local) by elasmtp-kukur.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1Ns45K-00085W-Ks; Wed, 17 Mar 2010 20:59:38 -0400 Message-ID: <4BA17AF9.9030107@earthlink.net> Date: Thu, 18 Mar 2010 00:59:00 -0000 From: Stan Shebs User-Agent: Thunderbird 2.0.0.23 (Macintosh/20090812) MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org, Marc Khouzam , Stan Shebs Subject: Re: [PATCH] No resuming while tfinding References: <4BA0377C.1040000@codesourcery.com> <201003171521.59901.pedro@codesourcery.com> In-Reply-To: <201003171521.59901.pedro@codesourcery.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da940367884fd299198b295bb43ab7e362e1f350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00642.txt.bz2 Pedro Alves wrote: > >> (until_command): Ditto. >> >> > This misses the "until" command, in breakpoint.c. > I'm guessing you mean until_break_command? It looks like it's lower level to until_command and advance_command, and I'd like to keep this test at the outermost levels, similarly to the "program is not running" error. >> >> extern void disconnect_or_stop_tracing (int from_tty); >> + extern int get_traceframe_number (void); >> > > This is unnecessary, get_traceframe_number is declared in > tracepoint.h. The disconnect_or_stop_tracing declaration > shown above could use moving there as well... > Good idea, I'll fold that in. Stan