From: Michael Snyder <msnyder@vmware.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [RFA 3/5] Prec: x86 segment register support: target
Date: Tue, 16 Mar 2010 18:12:00 -0000 [thread overview]
Message-ID: <4B9FCA21.9020904@vmware.com> (raw)
In-Reply-To: <daef60381003160948q7ba41966o76b6194cd7a8f1d0@mail.gmail.com>
Hui Zhu wrote:
> This patch add a interface to let GDB get segment base message from inferior.
>
> Thanks,
> Hui
>
> 2010-03-16 Hui Zhu <teawater@gmail.com>
>
> * target.c (update_current_target): Add to_get_segment_base.
> * target.h (target_ops): Ditto.
Hi Hui,
I'm glad you're doing this.
However, isn't target.c the wrong place for this function?
Wouldn't it belong better in the gdbarch? It is architecture-
specific, if I understand correctly.
That is, this will be the same between i386-ptrace and i386-remote,
but different between i386-remote and (say) mips-remote.
Michael
next prev parent reply other threads:[~2010-03-16 18:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 16:53 Hui Zhu
2010-03-16 18:12 ` Michael Snyder [this message]
2010-03-16 20:04 ` Daniel Jacobowitz
2010-03-22 14:03 ` Hui Zhu
2010-03-22 14:35 ` H.J. Lu
2010-03-22 14:44 ` Hui Zhu
2010-03-22 15:05 ` Mark Kettenis
2010-03-22 14:35 ` Mark Kettenis
2010-03-22 14:45 ` Hui Zhu
2010-03-22 14:53 ` Daniel Jacobowitz
2010-03-22 18:04 ` Eli Zaretskii
2010-03-22 18:14 ` Doug Evans
2010-03-22 16:03 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9FCA21.9020904@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox