From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19879 invoked by alias); 16 Mar 2010 18:12:57 -0000 Received: (qmail 19868 invoked by uid 22791); 16 Mar 2010 18:12:56 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Mar 2010 18:12:53 +0000 Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id CFBA71313E; Tue, 16 Mar 2010 11:12:49 -0700 (PDT) Received: from [10.20.124.100] (promd-2s-dhcp100.eng.vmware.com [10.20.124.100]) by jupiter.vmware.com (Postfix) with ESMTP id C361BDC1BE; Tue, 16 Mar 2010 11:12:49 -0700 (PDT) Message-ID: <4B9FCA21.9020904@vmware.com> Date: Tue, 16 Mar 2010 18:12:00 -0000 From: Michael Snyder User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Hui Zhu CC: gdb-patches ml Subject: Re: [RFA 3/5] Prec: x86 segment register support: target References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00604.txt.bz2 Hui Zhu wrote: > This patch add a interface to let GDB get segment base message from inferior. > > Thanks, > Hui > > 2010-03-16 Hui Zhu > > * target.c (update_current_target): Add to_get_segment_base. > * target.h (target_ops): Ditto. Hi Hui, I'm glad you're doing this. However, isn't target.c the wrong place for this function? Wouldn't it belong better in the gdbarch? It is architecture- specific, if I understand correctly. That is, this will be the same between i386-ptrace and i386-remote, but different between i386-remote and (say) mips-remote. Michael