Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Nick Clifton <nickc@redhat.com>
To: ams@gnu.org, schwab@redhat.com
Cc: binutils@sourceware.org, gdb-patches@sourceware.org,
	        gcc-patches@gcc.gnu.org
Subject: Re: Remove config.cache files when reconfiguring at top level
Date: Tue, 16 Feb 2010 12:40:00 -0000	[thread overview]
Message-ID: <4B7A9233.5040008@redhat.com> (raw)
In-Reply-To: <E1NhLWY-0003br-Qi@fencepost.gnu.org>

Hi Alfred, Hi Andreas,

>>       4. User runs make distclean.
>> 	There are no Makefiles present in the sub-directories so
>> 	the config.cache files are left intact.

> That seems like a bug, distclean should clean out everything not
> suitable for distribution, so config.cache files should definition not
> stay distclean.

> So clean them here.  That's the only correct place to do it.  Only
> distclean is allowed to remove configuration-recording files.

OK - so what do you guys think to this patch ?  (Presuming that I also 
revert my patch to configure.ac).

Cheers
   Nick

ChangeLog
2010-02-16  Nick Clifton  <nickc@redhat.com>

	PR 11238
	* Makefile.tpl (local-distclean): Also remove config.cache files in
	sub-directories as there may not be Makefiles present in the
	sub-directories.

Index: Makefile.tpl
===================================================================
RCS file: /cvs/src/src/Makefile.tpl,v
retrieving revision 1.214
diff -c -3 -p -r1.214 Makefile.tpl
*** Makefile.tpl        22 Jan 2010 16:28:24 -0000      1.214
--- Makefile.tpl        16 Feb 2010 12:37:35 -0000
*************** local-distclean:
*** 771,776 ****
--- 771,777 ----
         -rmdir texinfo/doc texinfo/info texinfo/intl texinfo/lib 
2>/dev/null
         -rmdir texinfo/makeinfo texinfo/po texinfo/util 2>/dev/null
         -rmdir fastjar gcc libiberty texinfo zlib 2>/dev/null
+       -find . -name config.cache -exec rm -f {} \; 2>/dev/null

   local-maintainer-clean:
         @echo "This command is intended for maintainers to use;"


  reply	other threads:[~2010-02-16 12:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 10:53 Nick Clifton
2010-02-15 10:58 ` Andreas Schwab
2010-02-15 15:54   ` Nick Clifton
2010-02-15 18:04     ` Andreas Schwab
2010-02-15 18:23       ` Alfred M. Szmidt
2010-02-15 19:37         ` Andreas Schwab
2010-02-16 11:23           ` Alfred M. Szmidt
2010-02-16 10:07       ` Nick Clifton
     [not found]       ` <4B7A6E32.6070307__49868.1737961762$1266314832$gmane$org@redhat.com>
2010-02-16 10:42         ` Andreas Schwab
2010-02-16 11:04           ` Nick Clifton
2010-02-16 11:12             ` Andreas Schwab
2010-02-16 11:23             ` Alfred M. Szmidt
2010-02-16 12:40               ` Nick Clifton [this message]
2010-02-16 13:25                 ` Alfred M. Szmidt
2010-02-16 14:03                   ` Andreas Schwab
2010-02-17 10:06                   ` Nick Clifton
2010-02-17 10:17                     ` Mark Kettenis
2010-02-17 11:04                       ` Nick Clifton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7A9233.5040008@redhat.com \
    --to=nickc@redhat.com \
    --cc=ams@gnu.org \
    --cc=binutils@sourceware.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox