From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27510 invoked by alias); 16 Feb 2010 12:40:38 -0000 Received: (qmail 27491 invoked by uid 22791); 16 Feb 2010 12:40:37 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 16 Feb 2010 12:40:35 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1GCeM9s028633 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 16 Feb 2010 07:40:23 -0500 Received: from [10.36.6.251] (vpn1-6-251.ams2.redhat.com [10.36.6.251]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1GCeK4V014843; Tue, 16 Feb 2010 07:40:21 -0500 Message-ID: <4B7A9233.5040008@redhat.com> Date: Tue, 16 Feb 2010 12:40:00 -0000 From: Nick Clifton User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 MIME-Version: 1.0 To: ams@gnu.org, schwab@redhat.com CC: binutils@sourceware.org, gdb-patches@sourceware.org, gcc-patches@gcc.gnu.org Subject: Re: Remove config.cache files when reconfiguring at top level References: <4B796E1D.7000104@redhat.com> <4B7A6E32.6070307__49868.1737961762$1266314832$gmane$org@redhat.com> <4B7A7B9E.4050606@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00385.txt.bz2 Hi Alfred, Hi Andreas, >> 4. User runs make distclean. >> There are no Makefiles present in the sub-directories so >> the config.cache files are left intact. > That seems like a bug, distclean should clean out everything not > suitable for distribution, so config.cache files should definition not > stay distclean. > So clean them here. That's the only correct place to do it. Only > distclean is allowed to remove configuration-recording files. OK - so what do you guys think to this patch ? (Presuming that I also revert my patch to configure.ac). Cheers Nick ChangeLog 2010-02-16 Nick Clifton PR 11238 * Makefile.tpl (local-distclean): Also remove config.cache files in sub-directories as there may not be Makefiles present in the sub-directories. Index: Makefile.tpl =================================================================== RCS file: /cvs/src/src/Makefile.tpl,v retrieving revision 1.214 diff -c -3 -p -r1.214 Makefile.tpl *** Makefile.tpl 22 Jan 2010 16:28:24 -0000 1.214 --- Makefile.tpl 16 Feb 2010 12:37:35 -0000 *************** local-distclean: *** 771,776 **** --- 771,777 ---- -rmdir texinfo/doc texinfo/info texinfo/intl texinfo/lib 2>/dev/null -rmdir texinfo/makeinfo texinfo/po texinfo/util 2>/dev/null -rmdir fastjar gcc libiberty texinfo zlib 2>/dev/null + -find . -name config.cache -exec rm -f {} \; 2>/dev/null local-maintainer-clean: @echo "This command is intended for maintainers to use;"