From: Nick Clifton <nickc@redhat.com>
To: Andreas Schwab <schwab@redhat.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org,
gcc-patches@gcc.gnu.org
Subject: Re: Remove config.cache files when reconfiguring at top level
Date: Tue, 16 Feb 2010 11:04:00 -0000 [thread overview]
Message-ID: <4B7A7B9E.4050606@redhat.com> (raw)
In-Reply-To: <m3y6itsbr2.fsf@hase.home>
Hi Andreas,
>> Is that OK with you ?
>
> Why can't you just put the config.cache removal into distclean? That's
> what the bug is all about anyway.
Because distclean is a Makefile target and the reconfigure deletes the
Makefiles, so there are no distclean targets to be run. What used to
happens was:
1. User runs configure.
Top level files are created but no sub-directories.
2. User runs make.
Sub-directories are created. Makefile and config.cache files
are created in the sub-directories.
3. User runs configure again, with different flags.
The configure script deletes the Makefiles that were created
in the sub-directories, but leaves the config.cache files alone.
4. User runs make distclean.
There are no Makefiles present in the sub-directories so
the config.cache files are left intact.
5. User runs make.
The build fails because the values in the config.cache files
in the sub-directories no longer match up with the values
specified in the reconfigure.
My patch made step 3 delete the config.cache files in directories where
a Makefile was being deleted so that step 5 would then execute successfully.
Cheers
Nick
next prev parent reply other threads:[~2010-02-16 11:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 10:53 Nick Clifton
2010-02-15 10:58 ` Andreas Schwab
2010-02-15 15:54 ` Nick Clifton
2010-02-15 18:04 ` Andreas Schwab
2010-02-15 18:23 ` Alfred M. Szmidt
2010-02-15 19:37 ` Andreas Schwab
2010-02-16 11:23 ` Alfred M. Szmidt
2010-02-16 10:07 ` Nick Clifton
[not found] ` <4B7A6E32.6070307__49868.1737961762$1266314832$gmane$org@redhat.com>
2010-02-16 10:42 ` Andreas Schwab
2010-02-16 11:04 ` Nick Clifton [this message]
2010-02-16 11:12 ` Andreas Schwab
2010-02-16 11:23 ` Alfred M. Szmidt
2010-02-16 12:40 ` Nick Clifton
2010-02-16 13:25 ` Alfred M. Szmidt
2010-02-16 14:03 ` Andreas Schwab
2010-02-17 10:06 ` Nick Clifton
2010-02-17 10:17 ` Mark Kettenis
2010-02-17 11:04 ` Nick Clifton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B7A7B9E.4050606@redhat.com \
--to=nickc@redhat.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=schwab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox