Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Chris Moller <cmoller@redhat.com>
To: tromey@redhat.com
Cc: gdb-patches@sourceware.org
Subject: Re: PR11067 patch
Date: Wed, 10 Feb 2010 03:03:00 -0000	[thread overview]
Message-ID: <4B722202.5010506@redhat.com> (raw)
In-Reply-To: <m3mxziynrb.fsf@fleche.redhat.com>

On 02/09/10 18:48, Tom Tromey wrote:
>
> My reason for not wanting this, aside from lack of any precedent, is
> based on my belief that the differences are aesthetic and not
> functional.  That leads me to conclude that in this case the cost

But what's the cost?  Functionally, it consists mostly of replacing an 
fputs_filtered with a vfprintf_filtered, so the performance hit is 
negligible, and the patch adds maybe a hundred lines of code, most of it 
in setting up the set enum-fmt command and translating the format strings.

> of another gdb option is outweighed by the triviality of the issue.
>    

Yep, so this is my last comment on the matter.


  reply	other threads:[~2010-02-10  3:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-06 13:37 Chris Moller
2010-02-06 19:40 ` Eli Zaretskii
2010-02-08 21:54 ` Tom Tromey
2010-02-08 22:08   ` Chris Moller
2010-02-08 22:32   ` Pedro Alves
2010-02-08 22:47     ` Chris Moller
2010-02-08 23:25       ` Pedro Alves
2010-02-09  4:13     ` Eli Zaretskii
2010-02-09  4:13     ` Joel Brobecker
2010-02-09 17:31   ` Chris Moller
2010-02-09 23:48     ` Tom Tromey
2010-02-10  3:03       ` Chris Moller [this message]
2010-02-10  8:19         ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B722202.5010506@redhat.com \
    --to=cmoller@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox