From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8336 invoked by alias); 10 Feb 2010 03:03:39 -0000 Received: (qmail 7940 invoked by uid 22791); 10 Feb 2010 03:03:38 -0000 X-SWARE-Spam-Status: No, hits=-7.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 10 Feb 2010 03:03:34 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1A33X2r023479 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 9 Feb 2010 22:03:33 -0500 Received: from qcore.mollernet.net (vpn-8-119.rdu.redhat.com [10.11.8.119]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o1A33UiY030774; Tue, 9 Feb 2010 22:03:30 -0500 Message-ID: <4B722202.5010506@redhat.com> Date: Wed, 10 Feb 2010 03:03:00 -0000 From: Chris Moller User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: tromey@redhat.com CC: gdb-patches@sourceware.org Subject: Re: PR11067 patch References: <4B6D70A3.2090208@redhat.com> <4B719BF6.1040207@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00268.txt.bz2 On 02/09/10 18:48, Tom Tromey wrote: > > My reason for not wanting this, aside from lack of any precedent, is > based on my belief that the differences are aesthetic and not > functional. That leads me to conclude that in this case the cost But what's the cost? Functionally, it consists mostly of replacing an fputs_filtered with a vfprintf_filtered, so the performance hit is negligible, and the patch adds maybe a hundred lines of code, most of it in setting up the set enum-fmt command and translating the format strings. > of another gdb option is outweighed by the triviality of the issue. > Yep, so this is my last comment on the matter.