Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Chris Moller <cmoller@redhat.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: PR11067 patch
Date: Wed, 10 Feb 2010 08:19:00 -0000	[thread overview]
Message-ID: <20100210081850.GA2907@adacore.com> (raw)
In-Reply-To: <4B722202.5010506@redhat.com>

> But what's the cost?  Functionally, it consists mostly of replacing
> an fputs_filtered with a vfprintf_filtered, so the performance hit
> is negligible, and the patch adds maybe a hundred lines of code,
> most of it in setting up the set enum-fmt command and translating
> the format strings.

One lesson we (AdaCore) learnt from developping GPS (AdaCore's IDE), is
that adding options and flexibility can quickly cause the amount of testing
to explode.

I agree with Tom in this case that it's better to not have the formatting
option.  I know it can be discouraging sometimes that everyone bikesheds
a bit on things that small.  I actually think it's a good thing that
people provide their opinions, even at the risk of mild bikeshedding.
I'd rather have all opinions now rather than later.

But there comes a point when we need to make a decision, and I think
we have reached that point (or went past it? ;-) ).  I personally like
Pedro's suggestion, but I'm ready to accept any format at all. I don't
think anyone really expressed a strong disagreement, so I'd just review
the thread, select the format that seemed to be prefered based on feedback,
and just announce that this is what you'll implement.  I'm sure some will
feel like they must propose something that's obviously nicer than your
proposal, but if there are no objection, I suggest we go with what you
announced in the end.

-- 
Joel


      reply	other threads:[~2010-02-10  8:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-06 13:37 Chris Moller
2010-02-06 19:40 ` Eli Zaretskii
2010-02-08 21:54 ` Tom Tromey
2010-02-08 22:08   ` Chris Moller
2010-02-08 22:32   ` Pedro Alves
2010-02-08 22:47     ` Chris Moller
2010-02-08 23:25       ` Pedro Alves
2010-02-09  4:13     ` Eli Zaretskii
2010-02-09  4:13     ` Joel Brobecker
2010-02-09 17:31   ` Chris Moller
2010-02-09 23:48     ` Tom Tromey
2010-02-10  3:03       ` Chris Moller
2010-02-10  8:19         ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100210081850.GA2907@adacore.com \
    --to=brobecker@adacore.com \
    --cc=cmoller@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox