Re: [python][patch] And range method to type

[Phil Muldoon <pmuldoon@redhat.com>]

On 12/04/2009 03:32 PM, Eli Zaretskii wrote:
>> Date: Fri, 04 Dec 2009 15:25:16 +0000
>> From: Phil Muldoon <pmuldoon@redhat.com>
>>
>> This patch adds a "range" method for GDB.Types.  It only supports types
>> that support a range, or the range type itself.
>>
>> Ok?
> 
> A couple of comments to the doco part:
> 
>> +@defmethod Type range
>> +Return a Python @code{Tuple} object that contains two elements.  The
>> +first element of the @code{Tuple} contains the low bound of the type; the
>> +second element contains the high bound of the type.


+@defmethod Type range
+Return a Python @code{Tuple} object that contains two elements: the
+low bound of the argument type and the high bound of that type.  If the 
+type does not have a range, @value{GDBN} will raise a @code{RuntimeError}.
+@end defmethod

With your suggestions, adding the missing full-stop and changing "throw" to "raise" 
in the exception case, is this ok?

Cheers,

Phil