From: Joel Brobecker <brobecker@adacore.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] And range method to type
Date: Fri, 04 Dec 2009 17:19:00 -0000 [thread overview]
Message-ID: <20091204171906.GC2891@adacore.com> (raw)
In-Reply-To: <4B1929DC.7070809@redhat.com>
This is not an official review, as I don't have much experience
exporting to Python, but it seems right to me. Just one minor
cosmetic comment:
> + if (TYPE_CODE (type) != TYPE_CODE_ARRAY &&
> + TYPE_CODE (type) != TYPE_CODE_STRING &&
> + TYPE_CODE (type) != TYPE_CODE_RANGE)
The && operators should be at the beginning of the line (GNU Coding
Standards):
if (TYPE_CODE (type) != TYPE_CODE_ARRAY
&& TYPE_CODE (type) != TYPE_CODE_STRING
&& TYPE_CODE (type) != TYPE_CODE_RANGE)
--
Joel
next prev parent reply other threads:[~2009-12-04 17:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-04 15:25 Phil Muldoon
2009-12-04 15:32 ` Eli Zaretskii
2009-12-04 17:10 ` Phil Muldoon
2009-12-04 19:30 ` Eli Zaretskii
2009-12-04 17:19 ` Joel Brobecker [this message]
2009-12-04 18:13 ` Tom Tromey
2009-12-05 9:19 ` Phil Muldoon
2009-12-05 9:22 ` Eli Zaretskii
2009-12-07 19:54 ` Tom Tromey
2009-12-08 14:14 ` Phil Muldoon
2009-12-09 3:00 ` Hui Zhu
2009-12-09 7:47 ` Phil Muldoon
2009-12-09 11:27 ` Eli Zaretskii
2009-12-09 11:41 ` Andreas Schwab
2009-12-09 7:52 ` Phil Muldoon
2009-12-09 7:56 ` Hui Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091204171906.GC2891@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pmuldoon@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox