From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68759-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 479 invoked by alias); 4 Dec 2009 17:19:15 -0000
Received: (qmail 469 invoked by uid 22791); 4 Dec 2009 17:19:14 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Dec 2009 17:19:11 +0000
Received: from localhost (localhost.localdomain [127.0.0.1]) 	by filtered-rock.gnat.com (Postfix) with ESMTP id D2A292BAB53; 	Fri,  4 Dec 2009 12:19:09 -0500 (EST)
Received: from rock.gnat.com ([127.0.0.1]) 	by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) 	with LMTP id rb9p0nbD-O4B; Fri,  4 Dec 2009 12:19:09 -0500 (EST)
Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) 	by rock.gnat.com (Postfix) with ESMTP id 69DBD2BAAA2; 	Fri,  4 Dec 2009 12:19:09 -0500 (EST)
Received: by joel.gnat.com (Postfix, from userid 1000) 	id 345E2F588A; Fri,  4 Dec 2009 09:19:06 -0800 (PST)
Date: Fri, 04 Dec 2009 17:19:00 -0000
From: Joel Brobecker <brobecker@adacore.com>
To: Phil Muldoon <pmuldoon@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [python][patch] And range method to type
Message-ID: <20091204171906.GC2891@adacore.com>
References: <4B1929DC.7070809@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4B1929DC.7070809@redhat.com>
User-Agent: Mutt/1.5.20 (2009-06-14)
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-12/txt/msg00057.txt.bz2

This is not an official review, as I don't have much experience
exporting to Python, but it seems right to me.  Just one minor
cosmetic comment:

> +  if (TYPE_CODE (type) != TYPE_CODE_ARRAY &&
> +      TYPE_CODE (type) != TYPE_CODE_STRING &&
> +      TYPE_CODE (type) != TYPE_CODE_RANGE)

The && operators should be at the beginning of the line (GNU Coding
Standards):

  if (TYPE_CODE (type) != TYPE_CODE_ARRAY
      && TYPE_CODE (type) != TYPE_CODE_STRING
      && TYPE_CODE (type) != TYPE_CODE_RANGE)

-- 
Joel