From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26602 invoked by alias); 4 Dec 2009 17:10:19 -0000 Received: (qmail 26586 invoked by uid 22791); 4 Dec 2009 17:10:18 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 04 Dec 2009 17:10:15 +0000 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nB4HABQ4016870 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 4 Dec 2009 12:10:11 -0500 Received: from localhost.localdomain (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nB4HA9sk028410; Fri, 4 Dec 2009 12:10:10 -0500 Message-ID: <4B194271.1060908@redhat.com> Date: Fri, 04 Dec 2009 17:10:00 -0000 From: Phil Muldoon User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [python][patch] And range method to type References: <4B1929DC.7070809@redhat.com> <834oo6lppw.fsf@gnu.org> In-Reply-To: <834oo6lppw.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00056.txt.bz2 On 12/04/2009 03:32 PM, Eli Zaretskii wrote: >> Date: Fri, 04 Dec 2009 15:25:16 +0000 >> From: Phil Muldoon >> >> This patch adds a "range" method for GDB.Types. It only supports types >> that support a range, or the range type itself. >> >> Ok? > > A couple of comments to the doco part: > >> +@defmethod Type range >> +Return a Python @code{Tuple} object that contains two elements. The >> +first element of the @code{Tuple} contains the low bound of the type; the >> +second element contains the high bound of the type. +@defmethod Type range +Return a Python @code{Tuple} object that contains two elements: the +low bound of the argument type and the high bound of that type. If the +type does not have a range, @value{GDBN} will raise a @code{RuntimeError}. +@end defmethod With your suggestions, adding the missing full-stop and changing "throw" to "raise" in the exception case, is this ok? Cheers, Phil