Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Marco Barisione <mbarisione@undo.io>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Add a way to preserve overridden GDB commands for later invocation
Date: Mon, 28 Oct 2019 18:12:00 -0000	[thread overview]
Message-ID: <4AFC40F6-7680-40C9-92D4-D0B1F66D344D@undo.io> (raw)
In-Reply-To: <83wocorcva.fsf@gnu.org>

On 28 Oct 2019, at 17:36, Eli Zaretskii <eliz@gnu.org> wrote:
>> +@var{preserve_when_overridden} is an optional argument.  If @code{True},
>> +then the new command is not deleted when it's overridden by another
>> +command with the same name, otherwise it's deleted.  When a command is
>> +preserved, the overriding command can still invoke it through its
>> +@code{invoke_overridden} method.
> 
> When you describe a complex new notion, it is important to use the
> same words consistently when referring to the same things.  In this
> case, you first used "not deleted", and later referred to the same
> thing as "preserved".  Not every reader will correctly conclude that
> these two mean the same.  So, to avoid confusion, use just one of the
> two in both instances, okay?

I was trying to make it clear that not being preserved means that the
object will be deleted, unless something holds a reference to it.  I
agree that this is not very clear.
Thanks for the feedback, I will fix this (and the other things as well).


-- 
Marco Barisione


  reply	other threads:[~2019-10-28 18:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 13:33 Marco Barisione
2019-10-28 17:36 ` Eli Zaretskii
2019-10-28 18:12   ` Marco Barisione [this message]
2019-11-01  8:55 ` [PATCH v2] " Marco Barisione
2019-11-01  9:14   ` Eli Zaretskii
2019-11-01 19:18   ` Tom Tromey
2019-11-01 21:01     ` Marco Barisione
2019-11-05 10:17       ` Andrew Burgess
2019-11-06  8:42         ` Marco Barisione
2019-11-07 10:22           ` Marco Barisione
2019-11-06 16:00         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AFC40F6-7680-40C9-92D4-D0B1F66D344D@undo.io \
    --to=mbarisione@undo.io \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox