From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62041 invoked by alias); 28 Oct 2019 18:12:54 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62032 invoked by uid 89); 28 Oct 2019 18:12:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=eli, HX-Languages-Length:1119 X-HELO: mail-wr1-f68.google.com Received: from mail-wr1-f68.google.com (HELO mail-wr1-f68.google.com) (209.85.221.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2019 18:12:52 +0000 Received: by mail-wr1-f68.google.com with SMTP id l10so10937730wrb.2 for ; Mon, 28 Oct 2019 11:12:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=undo-io.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=j6AGeWgdq+V+uWR8khiMe6iF1ft5piH1UZgLWsQoooQ=; b=0GcM+jFii8CYsABkZG53vTJMQSQ9hDdTO7KBuPe7jneg5XUl0sjJGoM20POF0y3teo Xd49/h0MKcHd6/bY9wEW27nrddtXJyNuP5nVGaB8wNK0sCtSZGxITRQ877V7ZQc+kKLa 7t7RNSinzgAJJY1EErV5QtbKgDEUprFGUXeWOyGBeFF+WTHpVT3brGYXQWaUEwpU58C2 sypOI9TjF5uVr51QJwmrHFMiJrV6VJqUR1JodTOcpbKT8w7/gLxzMzq0LF1vDFFGiNA2 fHBsCm3R3AaOy8bI5mIqwrkwEBEueita6phAQAwzMyQBHX+Tk0oC6pGnOop5ZcwDhr3a hx2w== Return-Path: Received: from [192.168.123.246] ([109.159.206.110]) by smtp.gmail.com with ESMTPSA id f18sm241156wmh.43.2019.10.28.11.12.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Oct 2019 11:12:49 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: [PATCH] Add a way to preserve overridden GDB commands for later invocation From: Marco Barisione In-Reply-To: <83wocorcva.fsf@gnu.org> Date: Mon, 28 Oct 2019 18:12:00 -0000 Cc: gdb-patches@sourceware.org Content-Transfer-Encoding: 7bit Message-Id: <4AFC40F6-7680-40C9-92D4-D0B1F66D344D@undo.io> References: <20191028133234.319-1-mbarisione@undo.io> <83wocorcva.fsf@gnu.org> To: Eli Zaretskii X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00994.txt.bz2 On 28 Oct 2019, at 17:36, Eli Zaretskii wrote: >> +@var{preserve_when_overridden} is an optional argument. If @code{True}, >> +then the new command is not deleted when it's overridden by another >> +command with the same name, otherwise it's deleted. When a command is >> +preserved, the overriding command can still invoke it through its >> +@code{invoke_overridden} method. > > When you describe a complex new notion, it is important to use the > same words consistently when referring to the same things. In this > case, you first used "not deleted", and later referred to the same > thing as "preserved". Not every reader will correctly conclude that > these two mean the same. So, to avoid confusion, use just one of the > two in both instances, okay? I was trying to make it clear that not being preserved means that the object will be deleted, unless something holds a reference to it. I agree that this is not very clear. Thanks for the feedback, I will fix this (and the other things as well). -- Marco Barisione