Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Marco Barisione <mbarisione@undo.io>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v2] Add a way to preserve overridden GDB commands for later invocation
Date: Fri, 01 Nov 2019 09:14:00 -0000	[thread overview]
Message-ID: <83h83om003.fsf@gnu.org> (raw)
In-Reply-To: <20191101085449.28493-1-mbarisione@undo.io> (message from Marco	Barisione on Fri, 1 Nov 2019 08:54:49 +0000)

> From: Marco Barisione <mbarisione@undo.io>
> Date: Fri,  1 Nov 2019 08:54:49 +0000
> 
> 2019-11-01  Marco Barisione  <mbarisione@undo.io>
> 
> 	Add support for preserving the functionalities from overridden
> 	commands.
> 	* cli/cli-decode.c (delete_cmd): Rename to remove_cmd.
> 	(remove_cmd): Allow commands to be preserved after overriding
> 	them.
> 	(do_add_cmd): Support the preservation of overridden commands.
> 	(add_alias_cmd): Use delete_cmd instead of remove_cmd and update
> 	the assertions.
> 	* cli/cli-decode.h (struct cmd_list_element): Add
> 	preserve_when_overridden and preserved_overridden_cmd.
> 	* cli/cli-script.c (do_define_command): Make default commands
> 	be preserved by default.
> 	* python/py-cmd.c (cmdpy_invoke_overridden): Add an
> 	invoke_overridden command method to gdb.Command.
> 	(cmdpy_init): Add a preserve_when_overridden argument to
> 	gdb.Command.__init__.
> 	* NEWS: Document the addition of gdb.Command.invoke_overridden
> 	and the new preserve_when_overridden argument for
> 	gdb.Command.__init__.
> 
> gdb/doc/ChangeLog:
> 
> 2019-11-01  Marco Barisione  <mbarisione@undo.io>
> 
> 	* python.texi (Commands In Python): Document
> 	gdb.Command.invoke_overridden and the new
> 	preserve_when_overridden argument for gdb.Command.__init__.
> 
> gdb/testsuite/ChangeLog:
> 
> 2019-11-01  Marco Barisione  <mbarisione@undo.io>
> 
> 	* gdb.python/py-chain-invoke.exp: New file.
> 	* gdb.python/py-chain-invoke.py: New test.

Thanks, the documentation parts are OK.


  reply	other threads:[~2019-11-01  9:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 13:33 [PATCH] " Marco Barisione
2019-10-28 17:36 ` Eli Zaretskii
2019-10-28 18:12   ` Marco Barisione
2019-11-01  8:55 ` [PATCH v2] " Marco Barisione
2019-11-01  9:14   ` Eli Zaretskii [this message]
2019-11-01 19:18   ` Tom Tromey
2019-11-01 21:01     ` Marco Barisione
2019-11-05 10:17       ` Andrew Burgess
2019-11-06  8:42         ` Marco Barisione
2019-11-07 10:22           ` Marco Barisione
2019-11-06 16:00         ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h83om003.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=mbarisione@undo.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox