Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Gutson <dgutson@codesourcery.com>
To: Daniel Gutson <dgutson@codesourcery.com>,
	  Michael Snyder <msnyder@vmware.com>,
	 "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gcore registers storing fix
Date: Mon, 09 Nov 2009 18:17:00 -0000	[thread overview]
Message-ID: <4AF85CC0.2030002@codesourcery.com> (raw)
In-Reply-To: <20091109153110.GA12924@caradoc.them.org>



Daniel Jacobowitz wrote:
> On Mon, Nov 09, 2009 at 11:59:26AM -0300, Daniel Gutson wrote:
>>> You say in your comment, "The threads should be standing at a
>>> known function, rather than ??".  I'm not sure how we can know
>>> that.  The threads may have been stopped anywhere, and it's
>>> always possible to find a library with no symbols.
>> What would you suggest? I could bound the check to the current frame.
> 
> How about we check that at least one thread is in "thread2"?  That's
> where gcore was used to create the core file.  Except, there's already
> a test for that in the file.  So maybe we do not need a new test.

The problem shows up when "in ??" appears. I think that the current 
thread will never be shown in that way unless the test does fail.
That being said, I think that I could add the regex for the "*" in order 
to looking into the current thread only.

Thoughts?

Thanks,
	Daniel.

-- 
Daniel Gutson
CodeSourcery
www.codesourcery.com


  reply	other threads:[~2009-11-09 18:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-06 22:37 Daniel Gutson
2009-11-08 20:04 ` Michael Snyder
2009-11-09 14:59   ` Daniel Gutson
2009-11-09 15:31     ` Daniel Jacobowitz
2009-11-09 18:17       ` Daniel Gutson [this message]
2009-11-09 18:25         ` Daniel Jacobowitz
2009-11-09 18:36           ` Daniel Gutson
2009-11-09 20:10             ` Daniel Jacobowitz
2009-11-09 20:32               ` Daniel Gutson
2009-11-09 20:33                 ` Daniel Jacobowitz
2009-11-09 20:37                   ` Daniel Gutson
2009-11-10 21:00                     ` Daniel Jacobowitz
2009-11-09 19:10       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF85CC0.2030002@codesourcery.com \
    --to=dgutson@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox