From: Daniel Jacobowitz <dan@codesourcery.com>
To: Daniel Gutson <dgutson@codesourcery.com>
Cc: Michael Snyder <msnyder@vmware.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] gcore registers storing fix
Date: Mon, 09 Nov 2009 20:33:00 -0000 [thread overview]
Message-ID: <20091109203352.GA11579@caradoc.them.org> (raw)
In-Reply-To: <4AF87C4C.8010504@codesourcery.com>
On Mon, Nov 09, 2009 at 05:32:12PM -0300, Daniel Gutson wrote:
>
>
> Daniel Jacobowitz wrote:
> >On Mon, Nov 09, 2009 at 03:36:02PM -0300, Daniel Gutson wrote:
> >>Because none of them checks that the text "in ??" does *not* show up
> >
> >Michael has pointed out that this text can legitimately appear.
> >If there is a function in the system libraries without debug
> >information, we may be there. For instance, inside the implementation
> >of printf.
>
> OK, should I just remove the test case then? That, or only check that
> the ?? is not in the current thread.
Let's drop the new test. The code part of your patch is OK to commit.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-11-09 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 22:37 Daniel Gutson
2009-11-08 20:04 ` Michael Snyder
2009-11-09 14:59 ` Daniel Gutson
2009-11-09 15:31 ` Daniel Jacobowitz
2009-11-09 18:17 ` Daniel Gutson
2009-11-09 18:25 ` Daniel Jacobowitz
2009-11-09 18:36 ` Daniel Gutson
2009-11-09 20:10 ` Daniel Jacobowitz
2009-11-09 20:32 ` Daniel Gutson
2009-11-09 20:33 ` Daniel Jacobowitz [this message]
2009-11-09 20:37 ` Daniel Gutson
2009-11-10 21:00 ` Daniel Jacobowitz
2009-11-09 19:10 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109203352.GA11579@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=dgutson@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox