From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4290 invoked by alias); 9 Nov 2009 18:17:54 -0000 Received: (qmail 4280 invoked by uid 22791); 9 Nov 2009 18:17:53 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 09 Nov 2009 18:17:49 +0000 Received: (qmail 3754 invoked from network); 9 Nov 2009 18:17:47 -0000 Received: from unknown (HELO ?192.168.9.129?) (daniel@127.0.0.2) by mail.codesourcery.com with ESMTPA; 9 Nov 2009 18:17:47 -0000 Message-ID: <4AF85CC0.2030002@codesourcery.com> Date: Mon, 09 Nov 2009 18:17:00 -0000 From: Daniel Gutson User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Daniel Gutson , Michael Snyder , "gdb-patches@sourceware.org" Subject: Re: [PATCH] gcore registers storing fix References: <4AF4A505.4010600@codesourcery.com> <4AF72404.1070808@vmware.com> <4AF82E4E.8000500@codesourcery.com> <20091109153110.GA12924@caradoc.them.org> In-Reply-To: <20091109153110.GA12924@caradoc.them.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00155.txt.bz2 Daniel Jacobowitz wrote: > On Mon, Nov 09, 2009 at 11:59:26AM -0300, Daniel Gutson wrote: >>> You say in your comment, "The threads should be standing at a >>> known function, rather than ??". I'm not sure how we can know >>> that. The threads may have been stopped anywhere, and it's >>> always possible to find a library with no symbols. >> What would you suggest? I could bound the check to the current frame. > > How about we check that at least one thread is in "thread2"? That's > where gcore was used to create the core file. Except, there's already > a test for that in the file. So maybe we do not need a new test. The problem shows up when "in ??" appears. I think that the current thread will never be shown in that way unless the test does fail. That being said, I think that I could add the regex for the "*" in order to looking into the current thread only. Thoughts? Thanks, Daniel. -- Daniel Gutson CodeSourcery www.codesourcery.com