Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [mingw32]  Fix some tests
@ 2009-11-03 16:28 Nathan Sidwell
  2009-11-03 16:31 ` Pedro Alves
  0 siblings, 1 reply; 2+ messages in thread
From: Nathan Sidwell @ 2009-11-03 16:28 UTC (permalink / raw)
  To: gdb-patches; +Cc: Pedro Alves

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

This patch of Pedro's fixes some x86-mingw tests.  That target also has a 
leading _ on symbols.

ok?

nathan
-- 
Nathan Sidwell    ::   http://www.codesourcery.com   ::         CodeSourcery


[-- Attachment #2: mingw-test.diff --]
[-- Type: text/plain, Size: 3009 bytes --]

2009-11-03  Pedro Alves  <pedro@codesourcery.com>

	* gdb.arch/i386-gnu-cfi.exp: Define SYMBOL_PREFIX on *-*-mingw*.
	* gdb.arch/i386-prologue.exp: Likewise.
	* gdb.arch/i386-unwind.exp: Likewise.

Index: gdb.arch/i386-gnu-cfi.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp,v
retrieving revision 1.4
diff -c -3 -p -r1.4 i386-gnu-cfi.exp
*** gdb.arch/i386-gnu-cfi.exp	3 Jan 2009 05:58:03 -0000	1.4
--- gdb.arch/i386-gnu-cfi.exp	3 Nov 2009 16:25:27 -0000
*************** set binfile ${objdir}/${subdir}/${testfi
*** 42,48 ****
  # some targets have leading underscores on assembly symbols.
  # TODO: detect this automatically
  set additional_flags ""
! if [istarget "i?86-*-cygwin*"] then {
    set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
  }
  
--- 42,48 ----
  # some targets have leading underscores on assembly symbols.
  # TODO: detect this automatically
  set additional_flags ""
! if { [istarget "*-*-cygwin*"] || [istarget "*-*-mingw*"] } then {
    set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
  }
  
Index: gdb.arch/i386-prologue.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-prologue.exp,v
retrieving revision 1.18
diff -c -3 -p -r1.18 i386-prologue.exp
*** gdb.arch/i386-prologue.exp	3 Jan 2009 05:58:03 -0000	1.18
--- gdb.arch/i386-prologue.exp	3 Nov 2009 16:25:27 -0000
*************** set binfile ${objdir}/${subdir}/${testfi
*** 40,46 ****
  # some targets have leading underscores on assembly symbols.
  # TODO: detect this automatically
  set additional_flags ""
! if [istarget "i?86-*-cygwin*"] then {
    set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
  }   
  
--- 40,46 ----
  # some targets have leading underscores on assembly symbols.
  # TODO: detect this automatically
  set additional_flags ""
! if { [istarget "*-*-cygwin*"] || [istarget "*-*-mingw*"] } then {
    set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
  }   
  
Index: gdb.arch/i386-unwind.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-unwind.exp,v
retrieving revision 1.9
diff -c -3 -p -r1.9 i386-unwind.exp
*** gdb.arch/i386-unwind.exp	3 Jan 2009 05:58:03 -0000	1.9
--- gdb.arch/i386-unwind.exp	3 Nov 2009 16:25:27 -0000
*************** set binfile ${objdir}/${subdir}/${testfi
*** 39,45 ****
  # some targets have leading underscores on assembly symbols.
  # TODO: detect this automatically
  set additional_flags ""
! if [istarget "i?86-*-cygwin*"] then {
    set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
  }
  
--- 39,45 ----
  # some targets have leading underscores on assembly symbols.
  # TODO: detect this automatically
  set additional_flags ""
! if { [istarget "*-*-cygwin*"] || [istarget "*-*-mingw*"] } then {
    set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
  }
  

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [mingw32]  Fix some tests
  2009-11-03 16:28 [mingw32] Fix some tests Nathan Sidwell
@ 2009-11-03 16:31 ` Pedro Alves
  0 siblings, 0 replies; 2+ messages in thread
From: Pedro Alves @ 2009-11-03 16:31 UTC (permalink / raw)
  To: Nathan Sidwell; +Cc: gdb-patches

On Tuesday 03 November 2009 16:27:48, Nathan Sidwell wrote:
> This patch of Pedro's fixes some x86-mingw tests.  That target also has a 
> leading _ on symbols.
> 
> ok?

Okay, thanks.

-- 
Pedro Alves


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-11-03 16:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-03 16:28 [mingw32] Fix some tests Nathan Sidwell
2009-11-03 16:31 ` Pedro Alves

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox