From: Nathan Sidwell <nathan@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Pedro Alves <pedro@codesourcery.com>
Subject: [mingw32] Fix some tests
Date: Tue, 03 Nov 2009 16:28:00 -0000 [thread overview]
Message-ID: <4AF05A04.9010103@codesourcery.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 192 bytes --]
This patch of Pedro's fixes some x86-mingw tests. That target also has a
leading _ on symbols.
ok?
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery
[-- Attachment #2: mingw-test.diff --]
[-- Type: text/plain, Size: 3009 bytes --]
2009-11-03 Pedro Alves <pedro@codesourcery.com>
* gdb.arch/i386-gnu-cfi.exp: Define SYMBOL_PREFIX on *-*-mingw*.
* gdb.arch/i386-prologue.exp: Likewise.
* gdb.arch/i386-unwind.exp: Likewise.
Index: gdb.arch/i386-gnu-cfi.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-gnu-cfi.exp,v
retrieving revision 1.4
diff -c -3 -p -r1.4 i386-gnu-cfi.exp
*** gdb.arch/i386-gnu-cfi.exp 3 Jan 2009 05:58:03 -0000 1.4
--- gdb.arch/i386-gnu-cfi.exp 3 Nov 2009 16:25:27 -0000
*************** set binfile ${objdir}/${subdir}/${testfi
*** 42,48 ****
# some targets have leading underscores on assembly symbols.
# TODO: detect this automatically
set additional_flags ""
! if [istarget "i?86-*-cygwin*"] then {
set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
}
--- 42,48 ----
# some targets have leading underscores on assembly symbols.
# TODO: detect this automatically
set additional_flags ""
! if { [istarget "*-*-cygwin*"] || [istarget "*-*-mingw*"] } then {
set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
}
Index: gdb.arch/i386-prologue.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-prologue.exp,v
retrieving revision 1.18
diff -c -3 -p -r1.18 i386-prologue.exp
*** gdb.arch/i386-prologue.exp 3 Jan 2009 05:58:03 -0000 1.18
--- gdb.arch/i386-prologue.exp 3 Nov 2009 16:25:27 -0000
*************** set binfile ${objdir}/${subdir}/${testfi
*** 40,46 ****
# some targets have leading underscores on assembly symbols.
# TODO: detect this automatically
set additional_flags ""
! if [istarget "i?86-*-cygwin*"] then {
set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
}
--- 40,46 ----
# some targets have leading underscores on assembly symbols.
# TODO: detect this automatically
set additional_flags ""
! if { [istarget "*-*-cygwin*"] || [istarget "*-*-mingw*"] } then {
set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
}
Index: gdb.arch/i386-unwind.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/i386-unwind.exp,v
retrieving revision 1.9
diff -c -3 -p -r1.9 i386-unwind.exp
*** gdb.arch/i386-unwind.exp 3 Jan 2009 05:58:03 -0000 1.9
--- gdb.arch/i386-unwind.exp 3 Nov 2009 16:25:27 -0000
*************** set binfile ${objdir}/${subdir}/${testfi
*** 39,45 ****
# some targets have leading underscores on assembly symbols.
# TODO: detect this automatically
set additional_flags ""
! if [istarget "i?86-*-cygwin*"] then {
set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
}
--- 39,45 ----
# some targets have leading underscores on assembly symbols.
# TODO: detect this automatically
set additional_flags ""
! if { [istarget "*-*-cygwin*"] || [istarget "*-*-mingw*"] } then {
set additional_flags "additional_flags=-DSYMBOL_PREFIX=\"_\""
}
next reply other threads:[~2009-11-03 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-03 16:28 Nathan Sidwell [this message]
2009-11-03 16:31 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF05A04.9010103@codesourcery.com \
--to=nathan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox