From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [RFA] comment looks wrong...
Date: Wed, 28 Oct 2009 19:31:00 -0000 [thread overview]
Message-ID: <4AE89A1F.2080502@vmware.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 195 bytes --]
The comment in findvar about extract_*_integer looked wrong to me,
with respect to target vs. host. If I'm right, this is an improvement,
but if I'm confused, then so are these comments. ;-/
[-- Attachment #2: findvar.txt --]
[-- Type: text/plain, Size: 1166 bytes --]
2009-10-28 Michael Snyder <msnyder@vmware.com>
* findvar.c (top level): Fix and add comments.
Index: findvar.c
===================================================================
RCS file: /cvs/src/src/gdb/findvar.c,v
retrieving revision 1.126
diff -u -p -r1.126 findvar.c
--- findvar.c 2 Jul 2009 17:25:53 -0000 1.126
+++ findvar.c 28 Oct 2009 19:28:48 -0000
@@ -36,8 +36,9 @@
#include "block.h"
#include "objfiles.h"
-/* Basic byte-swapping routines. GDB has needed these for a long time...
- All extract a target-format integer at ADDR which is LEN bytes long. */
+/* Basic byte-swapping routines. GDB has needed these for a long
+ time... All 'extract' functions extract a host-format integer at
+ ADDR which is LEN bytes long. */
#if TARGET_CHAR_BIT != 8 || HOST_CHAR_BIT != 8
/* 8 bit characters are a pretty safe assumption these days, so we
@@ -179,6 +180,8 @@ extract_typed_address (const gdb_byte *b
return gdbarch_pointer_to_address (get_type_arch (type), type, buf);
}
+/* All 'store' functions store a target-format integer at ADDR
+ which is LEN bytes long. */
void
store_signed_integer (gdb_byte *addr, int len,
next reply other threads:[~2009-10-28 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 19:31 Michael Snyder [this message]
2009-10-28 20:04 ` Daniel Jacobowitz
2009-11-01 18:28 ` Michael Snyder
2009-11-01 19:33 ` Daniel Jacobowitz
2009-11-01 20:37 ` Michael Snyder
2009-11-02 0:57 ` Daniel Jacobowitz
2009-11-11 19:27 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AE89A1F.2080502@vmware.com \
--to=msnyder@vmware.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox