From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] comment looks wrong...
Date: Wed, 28 Oct 2009 20:04:00 -0000 [thread overview]
Message-ID: <20091028200435.GA13464@caradoc.them.org> (raw)
In-Reply-To: <4AE89A1F.2080502@vmware.com>
On Wed, Oct 28, 2009 at 12:23:11PM -0700, Michael Snyder wrote:
> The comment in findvar about extract_*_integer looked wrong to me,
> with respect to target vs. host. If I'm right, this is an improvement,
> but if I'm confused, then so are these comments. ;-/
It's some subject/object fuzziness, I think.
> -/* Basic byte-swapping routines. GDB has needed these for a long time...
> - All extract a target-format integer at ADDR which is LEN bytes long. */
> +/* Basic byte-swapping routines. GDB has needed these for a long
> + time... All 'extract' functions extract a host-format integer at
> + ADDR which is LEN bytes long. */
Which do you extract - the value being read or the value being
returned? It means the value being read, which is in target format.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-10-28 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-28 19:31 Michael Snyder
2009-10-28 20:04 ` Daniel Jacobowitz [this message]
2009-11-01 18:28 ` Michael Snyder
2009-11-01 19:33 ` Daniel Jacobowitz
2009-11-01 20:37 ` Michael Snyder
2009-11-02 0:57 ` Daniel Jacobowitz
2009-11-11 19:27 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091028200435.GA13464@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox