From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22108 invoked by alias); 28 Oct 2009 20:04:45 -0000 Received: (qmail 21992 invoked by uid 22791); 28 Oct 2009 20:04:44 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Oct 2009 20:04:38 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 6212110E9F; Wed, 28 Oct 2009 20:04:36 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 3EC7E109F9; Wed, 28 Oct 2009 20:04:36 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1N3El1-0003ap-4b; Wed, 28 Oct 2009 16:04:35 -0400 Date: Wed, 28 Oct 2009 20:04:00 -0000 From: Daniel Jacobowitz To: Michael Snyder Cc: "gdb-patches@sourceware.org" Subject: Re: [RFA] comment looks wrong... Message-ID: <20091028200435.GA13464@caradoc.them.org> Mail-Followup-To: Michael Snyder , "gdb-patches@sourceware.org" References: <4AE89A1F.2080502@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AE89A1F.2080502@vmware.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00677.txt.bz2 On Wed, Oct 28, 2009 at 12:23:11PM -0700, Michael Snyder wrote: > The comment in findvar about extract_*_integer looked wrong to me, > with respect to target vs. host. If I'm right, this is an improvement, > but if I'm confused, then so are these comments. ;-/ It's some subject/object fuzziness, I think. > -/* Basic byte-swapping routines. GDB has needed these for a long time... > - All extract a target-format integer at ADDR which is LEN bytes long. */ > +/* Basic byte-swapping routines. GDB has needed these for a long > + time... All 'extract' functions extract a host-format integer at > + ADDR which is LEN bytes long. */ Which do you extract - the value being read or the value being returned? It means the value being read, which is in target format. -- Daniel Jacobowitz CodeSourcery