From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4646 invoked by alias); 28 Oct 2009 19:31:06 -0000 Received: (qmail 4637 invoked by uid 22791); 28 Oct 2009 19:31:05 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Oct 2009 19:31:01 +0000 Received: from mailhost3.vmware.com (mailhost3.vmware.com [10.16.27.45]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 21834C030 for ; Wed, 28 Oct 2009 12:30:58 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost3.vmware.com (Postfix) with ESMTP id D7A13CD9E6 for ; Wed, 28 Oct 2009 12:30:57 -0700 (PDT) Message-ID: <4AE89A1F.2080502@vmware.com> Date: Wed, 28 Oct 2009 19:31:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [RFA] comment looks wrong... Content-Type: multipart/mixed; boundary="------------010208070903020802010703" X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-10/txt/msg00675.txt.bz2 This is a multi-part message in MIME format. --------------010208070903020802010703 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-length: 195 The comment in findvar about extract_*_integer looked wrong to me, with respect to target vs. host. If I'm right, this is an improvement, but if I'm confused, then so are these comments. ;-/ --------------010208070903020802010703 Content-Type: text/plain; name="findvar.txt" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="findvar.txt" Content-length: 1166 2009-10-28 Michael Snyder * findvar.c (top level): Fix and add comments. Index: findvar.c =================================================================== RCS file: /cvs/src/src/gdb/findvar.c,v retrieving revision 1.126 diff -u -p -r1.126 findvar.c --- findvar.c 2 Jul 2009 17:25:53 -0000 1.126 +++ findvar.c 28 Oct 2009 19:28:48 -0000 @@ -36,8 +36,9 @@ #include "block.h" #include "objfiles.h" -/* Basic byte-swapping routines. GDB has needed these for a long time... - All extract a target-format integer at ADDR which is LEN bytes long. */ +/* Basic byte-swapping routines. GDB has needed these for a long + time... All 'extract' functions extract a host-format integer at + ADDR which is LEN bytes long. */ #if TARGET_CHAR_BIT != 8 || HOST_CHAR_BIT != 8 /* 8 bit characters are a pretty safe assumption these days, so we @@ -179,6 +180,8 @@ extract_typed_address (const gdb_byte *b return gdbarch_pointer_to_address (get_type_arch (type), type, buf); } +/* All 'store' functions store a target-format integer at ADDR + which is LEN bytes long. */ void store_signed_integer (gdb_byte *addr, int len, --------------010208070903020802010703--