* [RFA] sync reverse debug with pspace changes
@ 2009-10-20 18:51 Michael Snyder
2009-10-20 19:00 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Michael Snyder @ 2009-10-20 18:51 UTC (permalink / raw)
To: gdb-patches, Pedro Alves
[-- Attachment #1: Type: text/plain, Size: 130 bytes --]
Pedro, please check this for me and see if it's right.
It fixes 4 testsuite failures and doesn't introduce any new ones.
Michael
[-- Attachment #2: pspace.txt --]
[-- Type: text/plain, Size: 1022 bytes --]
2009-10-20 Michael Snyder <msnyder@msnyder-server.eng.vmware.com>
* infrun.c (handle_inferior_event): Add pspace field to sal
for reverse execution cases.
Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.413
diff -u -p -r1.413 infrun.c
--- infrun.c 19 Oct 2009 09:51:41 -0000 1.413
+++ infrun.c 20 Oct 2009 18:48:12 -0000
@@ -4261,6 +4261,7 @@ infrun: not switching back to stepped th
struct symtab_and_line tmp_sal;
tmp_sal = find_pc_line (ecs->stop_func_start, 0);
+ tmp_sal.pspace = get_frame_program_space (frame);
if (tmp_sal.line != 0)
{
if (execution_direction == EXEC_REVERSE)
@@ -4328,6 +4329,7 @@ infrun: not switching back to stepped th
struct symtab_and_line sr_sal;
init_sal (&sr_sal);
sr_sal.pc = ecs->stop_func_start;
+ sr_sal.pspace = get_frame_program_space (frame);
insert_step_resume_breakpoint_at_sal (gdbarch,
sr_sal, null_frame_id);
keep_going (ecs);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] sync reverse debug with pspace changes
2009-10-20 18:51 [RFA] sync reverse debug with pspace changes Michael Snyder
@ 2009-10-20 19:00 ` Pedro Alves
2009-10-20 19:47 ` Michael Snyder
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2009-10-20 19:00 UTC (permalink / raw)
To: gdb-patches; +Cc: Michael Snyder
On Tuesday 20 October 2009 19:45:30, Michael Snyder wrote:
> Pedro, please check this for me and see if it's right.
Yep, It is. Thanks for fixing it!
--
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] sync reverse debug with pspace changes
2009-10-20 19:00 ` Pedro Alves
@ 2009-10-20 19:47 ` Michael Snyder
0 siblings, 0 replies; 3+ messages in thread
From: Michael Snyder @ 2009-10-20 19:47 UTC (permalink / raw)
To: Pedro Alves; +Cc: gdb-patches
Pedro Alves wrote:
> On Tuesday 20 October 2009 19:45:30, Michael Snyder wrote:
>> Pedro, please check this for me and see if it's right.
>
> Yep, It is. Thanks for fixing it!
>
ok, committed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-10-20 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-20 18:51 [RFA] sync reverse debug with pspace changes Michael Snyder
2009-10-20 19:00 ` Pedro Alves
2009-10-20 19:47 ` Michael Snyder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox