Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
	  Pedro Alves <pedro@codesourcery.com>
Subject: [RFA] sync reverse debug with pspace changes
Date: Tue, 20 Oct 2009 18:51:00 -0000	[thread overview]
Message-ID: <4ADE054A.4060508@vmware.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 130 bytes --]

Pedro, please check this for me and see if it's right.
It fixes 4 testsuite failures and doesn't introduce any new ones.
Michael


[-- Attachment #2: pspace.txt --]
[-- Type: text/plain, Size: 1022 bytes --]

2009-10-20  Michael Snyder  <msnyder@msnyder-server.eng.vmware.com>

	* infrun.c (handle_inferior_event): Add pspace field to sal
	for reverse execution cases.

Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.413
diff -u -p -r1.413 infrun.c
--- infrun.c	19 Oct 2009 09:51:41 -0000	1.413
+++ infrun.c	20 Oct 2009 18:48:12 -0000
@@ -4261,6 +4261,7 @@ infrun: not switching back to stepped th
 	struct symtab_and_line tmp_sal;
 
 	tmp_sal = find_pc_line (ecs->stop_func_start, 0);
+	tmp_sal.pspace = get_frame_program_space (frame);
 	if (tmp_sal.line != 0)
 	  {
 	    if (execution_direction == EXEC_REVERSE)
@@ -4328,6 +4329,7 @@ infrun: not switching back to stepped th
 	  struct symtab_and_line sr_sal;
 	  init_sal (&sr_sal);
 	  sr_sal.pc = ecs->stop_func_start;
+	  sr_sal.pspace = get_frame_program_space (frame);
 	  insert_step_resume_breakpoint_at_sal (gdbarch, 
 						sr_sal, null_frame_id);
 	  keep_going (ecs);

             reply	other threads:[~2009-10-20 18:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20 18:51 Michael Snyder [this message]
2009-10-20 19:00 ` Pedro Alves
2009-10-20 19:47   ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADE054A.4060508@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox