Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: Hui Zhu <teawater@gmail.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>,
	  Anthony Green <green@moxielogic.com>
Subject: Re: [RFA/Prec] Add signal support for process record
Date: Mon, 31 Aug 2009 17:54:00 -0000	[thread overview]
Message-ID: <4A9C0B56.1030804@vmware.com> (raw)
In-Reply-To: <daef60380908310009r22a6fe91m5d00d9e9e4349e21@mail.gmail.com>

Hui Zhu wrote:
> 
> Hi guys,
> 
> After discussion with Michael,  we decide to deal with this issue step by step.
> This is the fix bug patch.  It will fix the after get sig, inferior
> get a lot of sig.  Please help me with it.

This takes care of the immediate problem, which is that the
signals get delivered over and over during the record mode.

Please check this in.


> 2009-08-31  Hui Zhu  <teawater@gmail.com>
> 
>         * record.c (record_resume_siggnal): Deleted.
>         (record_resume): Ditto.
>         (record_wait): Change record_resume_siggnal to
>         TARGET_SIGNAL_0.
> 
> ---
>  record.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- a/record.c
> +++ b/record.c
> @@ -514,7 +514,6 @@ record_close (int quitting)
>  }
> 
>  static int record_resume_step = 0;
> -static enum target_signal record_resume_siggnal;
>  static int record_resume_error;
> 
>  static void
> @@ -522,7 +521,6 @@ record_resume (struct target_ops *ops, p
>                 enum target_signal siggnal)
>  {
>    record_resume_step = step;
> -  record_resume_siggnal = siggnal;
> 
>    if (!RECORD_IS_REPLAY)
>      {
> @@ -638,7 +636,7 @@ record_wait (struct target_ops *ops,
>                         }
>                       record_beneath_to_resume (record_beneath_to_resume_ops,
>                                                 ptid, 1,
> -                                               record_resume_siggnal);
> +                                               TARGET_SIGNAL_0);
>                       continue;
>                     }
>                 }


  reply	other threads:[~2009-08-31 17:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-27 16:50 Hui Zhu
2009-08-30  3:09 ` Hui Zhu
2009-08-31  8:23   ` Hui Zhu
2009-08-31 17:54     ` Michael Snyder [this message]
2009-09-01  4:35       ` Hui Zhu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A9C0B56.1030804@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=green@moxielogic.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox