From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66389-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11530 invoked by alias); 31 Aug 2009 17:41:54 -0000
Received: (qmail 11522 invoked by uid 22791); 31 Aug 2009 17:41:54 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from smtp-outbound-2.vmware.com (HELO smtp-outbound-2.vmware.com) (65.115.85.73)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 31 Aug 2009 17:41:46 +0000
Received: from jupiter.vmware.com (mailhost5.vmware.com [10.16.68.131]) 	by smtp-outbound-2.vmware.com (Postfix) with ESMTP id A3A2915007; 	Mon, 31 Aug 2009 10:41:44 -0700 (PDT)
Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) 	by jupiter.vmware.com (Postfix) with ESMTP id 986A4DC0E5; 	Mon, 31 Aug 2009 10:41:44 -0700 (PDT)
Message-ID: <4A9C0B56.1030804@vmware.com>
Date: Mon, 31 Aug 2009 17:54:00 -0000
From: Michael Snyder <msnyder@vmware.com>
User-Agent: Thunderbird 1.5.0.12 (X11/20080411)
MIME-Version: 1.0
To: Hui Zhu <teawater@gmail.com>
CC: gdb-patches ml <gdb-patches@sourceware.org>,   Anthony Green <green@moxielogic.com>
Subject: Re: [RFA/Prec] Add signal support for process record
References: <daef60380908270835x6c3a6293s2c71f8c6195ea738@mail.gmail.com> 	<daef60380908292003n208cd9e2q8f9db45e918000f0@mail.gmail.com> <daef60380908310009r22a6fe91m5d00d9e9e4349e21@mail.gmail.com>
In-Reply-To: <daef60380908310009r22a6fe91m5d00d9e9e4349e21@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00588.txt.bz2

Hui Zhu wrote:
> 
> Hi guys,
> 
> After discussion with Michael,  we decide to deal with this issue step by step.
> This is the fix bug patch.  It will fix the after get sig, inferior
> get a lot of sig.  Please help me with it.

This takes care of the immediate problem, which is that the
signals get delivered over and over during the record mode.

Please check this in.


> 2009-08-31  Hui Zhu  <teawater@gmail.com>
> 
>         * record.c (record_resume_siggnal): Deleted.
>         (record_resume): Ditto.
>         (record_wait): Change record_resume_siggnal to
>         TARGET_SIGNAL_0.
> 
> ---
>  record.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- a/record.c
> +++ b/record.c
> @@ -514,7 +514,6 @@ record_close (int quitting)
>  }
> 
>  static int record_resume_step = 0;
> -static enum target_signal record_resume_siggnal;
>  static int record_resume_error;
> 
>  static void
> @@ -522,7 +521,6 @@ record_resume (struct target_ops *ops, p
>                 enum target_signal siggnal)
>  {
>    record_resume_step = step;
> -  record_resume_siggnal = siggnal;
> 
>    if (!RECORD_IS_REPLAY)
>      {
> @@ -638,7 +636,7 @@ record_wait (struct target_ops *ops,
>                         }
>                       record_beneath_to_resume (record_beneath_to_resume_ops,
>                                                 ptid, 1,
> -                                               record_resume_siggnal);
> +                                               TARGET_SIGNAL_0);
>                       continue;
>                     }
>                 }