Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@vmware.com>
To: "tromey@redhat.com" <tromey@redhat.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Dead variables, remote.c
Date: Wed, 12 Aug 2009 23:02:00 -0000	[thread overview]
Message-ID: <4A834911.8030209@vmware.com> (raw)
In-Reply-To: <m363d3fpmo.fsf@fleche.redhat.com>

Tom Tromey wrote:
>>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
> 
> Michael> While poking in remote.c I noticed some unused local variables,
> Michael> and (with gcc's help) found 28 of them in 16 functions.
> 
> Michael> Not a huge priority, but should actually make the code easier to
> Michael> understand...
> 
> Looks good to me.
> 
> FWIW, I think a patch to eliminate an unused variable falls into the
> "obvious" category (barring unusual circumstances).

Thanks, committed.  And thanks for the 'obvious' call.


      reply	other threads:[~2009-08-12 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01  2:31 Michael Snyder
2009-08-04 17:36 ` Tom Tromey
2009-08-12 23:02   ` Michael Snyder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A834911.8030209@vmware.com \
    --to=msnyder@vmware.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox