From: Tom Tromey <tromey@redhat.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] Dead variables, remote.c
Date: Tue, 04 Aug 2009 17:36:00 -0000 [thread overview]
Message-ID: <m363d3fpmo.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4A73A8DC.8070104@vmware.com> (Michael Snyder's message of "Fri\, 31 Jul 2009 19\:30\:52 -0700")
>>>>> "Michael" == Michael Snyder <msnyder@vmware.com> writes:
Michael> While poking in remote.c I noticed some unused local variables,
Michael> and (with gcc's help) found 28 of them in 16 functions.
Michael> Not a huge priority, but should actually make the code easier to
Michael> understand...
Looks good to me.
FWIW, I think a patch to eliminate an unused variable falls into the
"obvious" category (barring unusual circumstances).
Tom
next prev parent reply other threads:[~2009-08-04 17:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-01 2:31 Michael Snyder
2009-08-04 17:36 ` Tom Tromey [this message]
2009-08-12 23:02 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m363d3fpmo.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox