From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26828 invoked by alias); 12 Aug 2009 23:00:52 -0000 Received: (qmail 26781 invoked by uid 22791); 12 Aug 2009 23:00:51 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from smtp-outbound-1.vmware.com (HELO smtp-outbound-1.vmware.com) (65.115.85.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 12 Aug 2009 23:00:45 +0000 Received: from mailhost4.vmware.com (mailhost4.vmware.com [10.16.67.124]) by smtp-outbound-1.vmware.com (Postfix) with ESMTP id 1DBE218001; Wed, 12 Aug 2009 16:00:44 -0700 (PDT) Received: from [10.20.94.141] (msnyder-server.eng.vmware.com [10.20.94.141]) by mailhost4.vmware.com (Postfix) with ESMTP id 14D6CC9A34; Wed, 12 Aug 2009 16:00:44 -0700 (PDT) Message-ID: <4A834911.8030209@vmware.com> Date: Wed, 12 Aug 2009 23:02:00 -0000 From: Michael Snyder User-Agent: Thunderbird 1.5.0.12 (X11/20080411) MIME-Version: 1.0 To: "tromey@redhat.com" CC: "gdb-patches@sourceware.org" Subject: Re: [RFA] Dead variables, remote.c References: <4A73A8DC.8070104@vmware.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-08/txt/msg00174.txt.bz2 Tom Tromey wrote: >>>>>> "Michael" == Michael Snyder writes: > > Michael> While poking in remote.c I noticed some unused local variables, > Michael> and (with gcc's help) found 28 of them in 16 functions. > > Michael> Not a huge priority, but should actually make the code easier to > Michael> understand... > > Looks good to me. > > FWIW, I think a patch to eliminate an unused variable falls into the > "obvious" category (barring unusual circumstances). Thanks, committed. And thanks for the 'obvious' call.