From: Dave Korn <dave.korn.cygwin@googlemail.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: binutils@sourceware.org,
Dave Korn <dave.korn.cygwin@googlemail.com>,
Tom Tromey <tromey@redhat.com>,
gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: How to get file descriptor from abfd?
Date: Thu, 11 Jun 2009 03:28:00 -0000 [thread overview]
Message-ID: <4A307CA0.2000501@gmail.com> (raw)
In-Reply-To: <8ac60eac0906101009r831248ej4638bb0cf12b8305@mail.gmail.com>
Paul Pluzhnikov wrote:
> Index: bfdio.c
> ===================================================================
> +. void* (*bmmap) (struct bfd *abfd, void *addr, bfd_size_type len,
> +. int prot, int flags, file_ptr offset);
That should probably be void-space-star-bracket, to match:
> + /* Just like mmap: (void*)-1 on failure, mmapped address on success. */
> + void *(*bmmap) (struct bfd *abfd, void *addr, bfd_size_type len,
... but it's not important enough to fix now and can be left for whoever's
working in that area next.
cheers,
DaveK
prev parent reply other threads:[~2009-06-11 3:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-31 17:56 Paul Pluzhnikov
2009-05-31 18:12 ` Dave Korn
2009-06-02 5:55 ` Paul Pluzhnikov
2009-06-08 16:10 ` Paul Pluzhnikov
2009-06-10 15:14 ` Dave Korn
2009-06-10 17:09 ` Paul Pluzhnikov
2009-06-10 23:59 ` Alan Modra
2009-06-11 0:42 ` Paul Pluzhnikov
2009-06-11 2:14 ` Dave Korn
2009-06-11 3:28 ` Dave Korn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A307CA0.2000501@gmail.com \
--to=dave.korn.cygwin@googlemail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox