From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-64401-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20139 invoked by alias); 11 Jun 2009 03:28:21 -0000
Received: (qmail 20123 invoked by uid 22791); 11 Jun 2009 03:28:21 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mail-ew0-f228.google.com (HELO mail-ew0-f228.google.com) (209.85.219.228)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 11 Jun 2009 03:28:15 +0000
Received: by ewy28 with SMTP id 28so1061384ewy.24         for <multiple recipients>; Wed, 10 Jun 2009 20:28:12 -0700 (PDT)
Received: by 10.210.39.2 with SMTP id m2mr4961092ebm.13.1244690892516;         Wed, 10 Jun 2009 20:28:12 -0700 (PDT)
Received: from ?192.168.2.99? (cpc2-cmbg8-0-0-cust61.cmbg.cable.ntl.com [82.6.108.62])         by mx.google.com with ESMTPS id 5sm554639eyf.38.2009.06.10.20.28.11         (version=SSLv3 cipher=RC4-MD5);         Wed, 10 Jun 2009 20:28:12 -0700 (PDT)
Message-ID: <4A307CA0.2000501@gmail.com>
Date: Thu, 11 Jun 2009 03:28:00 -0000
From: Dave Korn <dave.korn.cygwin@googlemail.com>
User-Agent: Thunderbird 2.0.0.17 (Windows/20080914)
MIME-Version: 1.0
To: Paul Pluzhnikov <ppluzhnikov@google.com>
CC: binutils@sourceware.org, Dave Korn <dave.korn.cygwin@googlemail.com>,   Tom Tromey <tromey@redhat.com>,  gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: How to get file descriptor from abfd?
References: <8ac60eac0905311056l3b8edf98rc6abfe28853e0b6d@mail.gmail.com>	 <4A22CB56.3070704@gmail.com>	 <8ac60eac0906012254o57756790y9bb4eb23d1d6e5a1@mail.gmail.com>	 <8ac60eac0906080910x6497e1abg5c7aa9bdf863c5d5@mail.gmail.com>	 <4A2FD0A7.2090408@gmail.com> <8ac60eac0906101009r831248ej4638bb0cf12b8305@mail.gmail.com>
In-Reply-To: <8ac60eac0906101009r831248ej4638bb0cf12b8305@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-06/txt/msg00288.txt.bz2

Paul Pluzhnikov wrote:

> Index: bfdio.c
> ===================================================================

> +.  void* (*bmmap) (struct bfd *abfd, void *addr, bfd_size_type len,
> +.                  int prot, int flags, file_ptr offset);

  That should probably be void-space-star-bracket, to match:

> +  /* Just like mmap: (void*)-1 on failure, mmapped address on success.  */
> +  void *(*bmmap) (struct bfd *abfd, void *addr, bfd_size_type len,

... but it's not important enough to fix now and can be left for whoever's
working in that area next.

    cheers,
      DaveK